From 06c25a9881b76f7e0b0ab27050d8c470fe9bdc2d Mon Sep 17 00:00:00 2001 From: jackhou Date: Wed, 29 Jul 2015 20:11:18 -0700 Subject: [Mac] Remove BrowserCommandExecutor protocol. Only BrowserWindowController implements this. Other implementors just turn it into a no-op. ChromeEventProcessingWindow (CEPW) now simply checks whether it's a Browser window and executes the command. This is the first step to factor out keyboard shortcut handling in CEPW into a component that can be reused in Views as it removes one (of two) dependencies on -[NSWindow windowController], which cannot be used to implement browser-side behavior under Views. Added new browser_test for shortcuts in global_keyboard_shortcuts_mac. Some history: BrowserCommandExecutor was added in r30619 (6 years ago) to allow a non-browser window to execute browser commands, but became obsolete a month later in r32445 when HtmlDialogWindowController (now WebDialogWindowController) decided to ignore those commands instead. BUG=508438 Review URL: https://codereview.chromium.org/1250533003 Cr-Commit-Position: refs/heads/master@{#341062} --- chrome/chrome_tests.gypi | 1 + 1 file changed, 1 insertion(+) (limited to 'chrome/chrome_tests.gypi') diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi index 943e5b3..e263909 100644 --- a/chrome/chrome_tests.gypi +++ b/chrome/chrome_tests.gypi @@ -294,6 +294,7 @@ 'browser/first_run/try_chrome_dialog_view_browsertest.cc', 'browser/geolocation/access_token_store_browsertest.cc', 'browser/geolocation/geolocation_browsertest.cc', + 'browser/global_keyboard_shortcuts_mac_browsertest.mm', 'browser/history/history_browsertest.cc', 'browser/history/redirect_browsertest.cc', 'browser/iframe_browsertest.cc', -- cgit v1.1