From 25b702d2edd1cf8bb383d169308f96cd1d23ea9d Mon Sep 17 00:00:00 2001 From: georgesak Date: Thu, 9 Jul 2015 08:50:18 -0700 Subject: Revert of New Task Manager - Phase 1.3.2: Implement Tab Contents Task Providing (patchset #3 id:40001 of https://codereview.chromium.org/1212663002/) Reason for revert: Reverting this because it makes the following test flaky: BackgroundContentsTagTest.PreExistingTasksAreProvided See example of failure here: https://commondatastorage.googleapis.com/chromium-build-logs/logs/2015/7/ahVzfmNocm9taXVtLWJ1aWxkLWxvZ3NynAELEgVCdWlsZCJ7MSAtIGh0dHA6Ly9idWlsZC5jaHJvbWl1bS5vcmcvcC9jaHJvbWl1bS5jaHJvbWl1bW9zL2pzb24gLSBMaW51eCBDaHJvbWl1bU9TIFRlc3RzIChkYmcpKDEpIC0gNDM4OCAtIDE0MzYzOTkyODIgLSAxNDM2NDAwNzQxDAsSCUJ1aWxkU3RlcBiAgICAgOSVCQw Error message: ../../chrome/browser/task_management/providers/web_contents/background_contents_tag_browsertest.cc:117: Failure Value of: task->title() Actual: Tab: about:blank Expected: GetBackgroundTaskExpectedName(extension) Which is: Background Page: app_process_background_instances Original issue's description: > New Task Manager - Phase 1.3.2: Implement Tab Contents Task Providing > > Part 3 of 3: Implementing a task-manager representation of WebContents > owned > by the TabStripModel. > > R=nick@chromium.org > BUG=470990 > TEST=browser_tests --gtest_filter=TabContentsTagTest.* > > Committed: https://crrev.com/543b07d4fb0b807639e8d29a0249794f240db091 > Cr-Commit-Position: refs/heads/master@{#337936} TBR=nick@chromium.org,gavinp@chromium.org,pkasting@chromium.org,avi@chromium.org,davidben@chromium.org,afakhry@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=470990 Review URL: https://codereview.chromium.org/1229923002 Cr-Commit-Position: refs/heads/master@{#338051} --- chrome/chrome_tests.gypi | 3 --- 1 file changed, 3 deletions(-) (limited to 'chrome/chrome_tests.gypi') diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi index 142639a..f5c869f 100644 --- a/chrome/chrome_tests.gypi +++ b/chrome/chrome_tests.gypi @@ -406,9 +406,6 @@ 'browser/tab_contents/view_source_browsertest.cc', 'browser/task_management/providers/web_contents/background_contents_tag_browsertest.cc', 'browser/task_management/providers/web_contents/devtools_tag_browsertest.cc', - 'browser/task_management/providers/web_contents/tab_contents_tag_browsertest.cc', - 'browser/task_management/task_management_browsertest_util.cc', - 'browser/task_management/task_management_browsertest_util.h', 'browser/task_manager/task_manager_browsertest.cc', 'browser/task_manager/task_manager_browsertest_util.cc', 'browser/task_manager/task_manager_browsertest_util.h', -- cgit v1.1