From bad77bf7b76ecaa884dd1cba56eeefd94e219c30 Mon Sep 17 00:00:00 2001 From: "aa@chromium.org" Date: Sat, 21 Aug 2010 21:21:22 +0000 Subject: Remove attempt to be smart about where to open navigations targetting app tabs. I futzed with this a bit to try and integrate installed apps extents, but it is complex. Also, I looked over the original bug where this code was added: crbug.com/29281. The issue there was that when you click on a bookmark (presumably in the bookmark bar) the pinned tab is unexpectedly overwritten. I can see that complaint, but there is also the use case of clicking a bookmark and intending it to overwrite the pinned tab. In summary, I kinda feel like the expectations about how navigation should work are too ingrained and we shouldn't be meddling. BUG=52680 Review URL: http://codereview.chromium.org/3161037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57002 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/chrome_tests.gypi | 1 - 1 file changed, 1 deletion(-) (limited to 'chrome/chrome_tests.gypi') diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi index 6323db8..1abf452 100644 --- a/chrome/chrome_tests.gypi +++ b/chrome/chrome_tests.gypi @@ -844,7 +844,6 @@ 'browser/browser_commands_unittest.cc', 'browser/browser_theme_pack_unittest.cc', 'browser/browser_theme_provider_unittest.cc', - 'browser/browser_unittest.cc', 'browser/browsing_data_appcache_helper_unittest.cc', 'browser/browsing_data_database_helper_unittest.cc', 'browser/browsing_data_local_storage_helper_unittest.cc', -- cgit v1.1