From e59558b78e8c6a1b0bd916a724724b638c3c91b6 Mon Sep 17 00:00:00 2001 From: "dcheng@chromium.org" Date: Tue, 9 Apr 2013 05:45:17 +0000 Subject: Rewrite std::string("") to std::string(), Linux edition. This patch was generated by running the empty_string clang tool across the Chromium Linux compilation database. Implicitly or explicitly constructing std::string() with a "" argument is inefficient as the caller needs to emit extra instructions to pass an argument, and the constructor needlessly copies a byte into internal storage. Rewriting these instances to simply call the default constructor appears to save ~14-18 kilobytes on an optimized release build. BUG=none Review URL: https://codereview.chromium.org/13145003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/common/extensions/api/commands/commands_handler.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'chrome/common/extensions/api/commands/commands_handler.cc') diff --git a/chrome/common/extensions/api/commands/commands_handler.cc b/chrome/common/extensions/api/commands/commands_handler.cc index 309a204..b5ed3c4 100644 --- a/chrome/common/extensions/api/commands/commands_handler.cc +++ b/chrome/common/extensions/api/commands/commands_handler.cc @@ -137,8 +137,10 @@ void CommandsHandler::MaybeSetBrowserActionDefault(const Extension* extension, CommandsInfo* info) { if (extension->manifest()->HasKey(keys::kBrowserAction) && !info->browser_action_command.get()) { - info->browser_action_command.reset(new Command( - extension_manifest_values::kBrowserActionCommandEvent, string16(), "")); + info->browser_action_command.reset( + new Command(extension_manifest_values::kBrowserActionCommandEvent, + string16(), + std::string())); } } -- cgit v1.1