From 49a7c77691cc0eaa2a7028ce51cd6de9edc78c4e Mon Sep 17 00:00:00 2001 From: "xji@chromium.org" Date: Fri, 21 May 2010 18:32:35 +0000 Subject: Fix problem of displaying title with parenthesis in extension. Wrap title with correctly bidi control characters in windows for display purpose. BUG=43485 TEST=1. open RTL chrome. 2. install Google dictionary extension. 3. extension title "Google Dictionary (by Google)" should be displayed as is in chrome://extensions page, 4. right click the extension icon, title "Google Dictionary (by Google)" should be displayed in extension context menu, 5. extension title should be displayed correctly in other places, such as task manager, etc. Review URL: http://codereview.chromium.org/2015004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47937 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/common/extensions/extension.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'chrome/common/extensions/extension.h') diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h index 99f7898..9063b12 100644 --- a/chrome/common/extensions/extension.h +++ b/chrome/common/extensions/extension.h @@ -421,7 +421,10 @@ class Extension { // The extension's version. scoped_ptr version_; - // The extension's human-readable name. + // The extension's human-readable name. Name is used for display purpose. It + // might be wrapped with unicode bidi control characters so that it is + // displayed correctly in RTL context. + // NOTE: Name is UTF-8 and may contain non-ascii characters. std::string name_; // An optional longer description of the extension. -- cgit v1.1