From 3e377c5a80be45d36a6015c80d9e2dae525cf042 Mon Sep 17 00:00:00 2001 From: "aa@chromium.org" <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Thu, 6 Aug 2009 07:46:37 +0000 Subject: Revert of r22559. This caused an easily reproducible crash: 1. Start with a fresh profile 2. Navigate to google.com 3. Restart 4. Navigate to google.com 5. crash The change from pass-by-value to pass-by-ref in fav_icon_helper.* seems to be to blame, but I can't see it right off. TBR=phajdan.jr@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22595 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/common/child_thread.cc | 2 +- chrome/common/child_thread.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'chrome/common') diff --git a/chrome/common/child_thread.cc b/chrome/common/child_thread.cc index 8e9e90c..9168570 100644 --- a/chrome/common/child_thread.cc +++ b/chrome/common/child_thread.cc @@ -22,7 +22,7 @@ ChildThread::ChildThread() { Init(); } -ChildThread::ChildThread(const std::string& channel_name) +ChildThread::ChildThread(const std::string channel_name) : channel_name_(channel_name) { Init(); } diff --git a/chrome/common/child_thread.h b/chrome/common/child_thread.h index afcd803..91ea9b7 100644 --- a/chrome/common/child_thread.h +++ b/chrome/common/child_thread.h @@ -20,7 +20,7 @@ class ChildThread : public IPC::Channel::Listener, // Creates the thread. ChildThread(); // Used for single-process mode. - ChildThread(const std::string& channel_name); + ChildThread(const std::string channel_name); virtual ~ChildThread(); // IPC::Message::Sender implementation: -- cgit v1.1