From 666ecd28cc344446d27d8748a21dfa3788e5462b Mon Sep 17 00:00:00 2001 From: "willchan@chromium.org" Date: Thu, 14 May 2009 04:57:14 +0000 Subject: Linux: Delay the deletion of the RWHVGtk object. This object may be deleted within a signal handler for its widget, which causes a DCHECK. Fix by using MessageLoop::DeleteSoon() instead. BUG=http://www.crbug.com/11847 TEST=Open browser, navigate to www.google.com. Navigate to www.yahoo.com. This will delete the old RWHV. It shouldn't crash. Review URL: http://codereview.chromium.org/113316 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16039 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/common/owned_widget_gtk.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'chrome/common') diff --git a/chrome/common/owned_widget_gtk.cc b/chrome/common/owned_widget_gtk.cc index 846cd1e..6b4f0d5 100644 --- a/chrome/common/owned_widget_gtk.cc +++ b/chrome/common/owned_widget_gtk.cc @@ -35,6 +35,6 @@ void OwnedWidgetGtk::Destroy() { DCHECK(!g_object_is_floating(widget)); // NOTE: Assumes some implementation details about glib internals. - DCHECK(G_OBJECT(widget)->ref_count == 1); + DCHECK_EQ(G_OBJECT(widget)->ref_count, 1U); g_object_unref(widget); } -- cgit v1.1