From d921e845da88fb6a132dfb702ee787adac2a804a Mon Sep 17 00:00:00 2001
From: "craig.schlenter@chromium.org"
 <craig.schlenter@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Mon, 11 Jan 2010 16:26:07 +0000
Subject: Extensions: Ensure that variable strings passed to ParseError aren't
 interpreted as format strings.

BUG=31085

Review URL: http://codereview.chromium.org/523131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35904 0039d316-1c4b-4281-b951-d872f2087c98
---
 chrome/common/extensions/update_manifest.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'chrome/common')

diff --git a/chrome/common/extensions/update_manifest.cc b/chrome/common/extensions/update_manifest.cc
index d6317c1..e3f1b4d 100644
--- a/chrome/common/extensions/update_manifest.cc
+++ b/chrome/common/extensions/update_manifest.cc
@@ -193,7 +193,7 @@ bool UpdateManifest::Parse(const std::string& manifest_xml) {
   ScopedXmlDocument document(xmlParseDoc(
       reinterpret_cast<const xmlChar*>(manifest_xml.c_str())));
   if (!document.get()) {
-    ParseError(xml_errors.c_str());
+    ParseError("%s", xml_errors.c_str());
     return false;
   }
 
@@ -228,7 +228,7 @@ bool UpdateManifest::Parse(const std::string& manifest_xml) {
     Result current;
     std::string error;
     if (!ParseSingleAppTag(apps[i], gupdate_ns, &current, &error)) {
-      ParseError(error.c_str());
+      ParseError("%s", error.c_str());
       return false;
     }
     results_.push_back(current);
-- 
cgit v1.1