From 7b908c0aedf17bed5a8099a47d872b58b7badfde Mon Sep 17 00:00:00 2001 From: noel Date: Mon, 13 Jul 2015 04:30:07 -0700 Subject: Revert of Add support for escaped target names in isolate driver (4th try) (patchset #2 id:20001 of https://codereview.chromium.org/1221333013/) Reason for revert: Speculative revert: appreas to have broken the GPU mac builders. http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%2010.9%20%28Intel%29%20%28dbg%29/builds/11045 .. 11141 Original issue's description: > Add support for escaped target names in isolate driver (4th try) > > Currently the isolate_driver.py which creates the dependency files > used by the isolate system, does a simple split on all spaces when > trying to identify targets. > > This can fail if the target name contains a space in the name. In > ninja, spaces are escaped with a $-prefix. An example would be > 'Content$ Shell$ Helper.app'. > > This CL adds support for such target names and ensures that they > stay as one item. Doing this uncovered a few missing dependencies > and a missing file in some .isolate-files for the component build > on Mac. > > 1st try: https://codereview.chromium.org/970203003/ > 1st revert: https://codereview.chromium.org/985753002/ > 2nd try: https://codereview.chromium.org/1103793002/ > 2nd revert: https://codereview.chromium.org/1129493003/ > 3rd try: https://codereview.chromium.org/1130523003/ > 3rd revert: https://codereview.chromium.org/1131363003/ > BUG=462248 > > Committed: https://crrev.com/c58992cc880b5bff5813276ee9d20a79be70b31f > Cr-Commit-Position: refs/heads/master@{#338402} TBR=thakis@chromium.org,vadimsh@chromium.org,nyquist@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462248 Review URL: https://codereview.chromium.org/1227843004 Cr-Commit-Position: refs/heads/master@{#338497} --- chrome/interactive_ui_tests.isolate | 1 - 1 file changed, 1 deletion(-) (limited to 'chrome/interactive_ui_tests.isolate') diff --git a/chrome/interactive_ui_tests.isolate b/chrome/interactive_ui_tests.isolate index c6959fb..1a5c74b 100644 --- a/chrome/interactive_ui_tests.isolate +++ b/chrome/interactive_ui_tests.isolate @@ -142,6 +142,5 @@ 'includes': [ '../base/base.isolate', '../gin/v8.isolate', - 'chrome.isolate', ], } -- cgit v1.1