From 93156cecb487ad7f1d7e307618cd58bd6546da29 Mon Sep 17 00:00:00 2001 From: "jam@chromium.org" Date: Mon, 12 Sep 2011 21:14:44 +0000 Subject: Make the NaCl windows 64 bit binaries not depend on chrome targets. These targets are very simple and used little code from chrome targets. However their dependency on chrome targets was problematic because a lot of code wasn't being built for 64 bit on Windows, and so there were a lot of "dummy" files being added with stub functions and code was also being compiled out in random places for NACL_WIN64. I've made the NaCl 64 bit windows targets self contained. They do use a few files from common, but those files are self-contained. In the future, we could move these to be in the same 64 bit target as the constants from common. However that won't make a maintenance difference since someone could still introduce link dependencies to other files in common. Additionally, since we're not using chrome code anymore, we can avoid having both nacl.exe and nacl.dll. nacl.exe is sufficient, and this saves 1.4MB of uncompresed binaries in the installer. BUG=86322 Review URL: http://codereview.chromium.org/7863024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100767 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/nacl/nacl_helper_linux.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'chrome/nacl/nacl_helper_linux.cc') diff --git a/chrome/nacl/nacl_helper_linux.cc b/chrome/nacl/nacl_helper_linux.cc index 7ffeadb..3f8646f 100644 --- a/chrome/nacl/nacl_helper_linux.cc +++ b/chrome/nacl/nacl_helper_linux.cc @@ -47,8 +47,8 @@ void BecomeNaClLoader(const std::vector& child_fds) { } MessageLoopForIO main_message_loop; - NaClListener *listener = new NaClListener(); - listener->Listen(); + NaClListener listener; + listener.Listen(); _exit(0); } -- cgit v1.1