From 901bc6f0153757765b80d34f0c3866747f1820e5 Mon Sep 17 00:00:00 2001 From: "avi@chromium.org" Date: Fri, 25 Oct 2013 20:47:00 +0000 Subject: Do not set process names in the Activity Monitor. This involves Process Manager functions, which in 10.9 cause a WindowServer checkin, which causes "not responding" notifications on any child process that doesn't pump events (which is everything but the renderers). BUG=304860 TEST=Plugin process on Mavericks shouldn't have an app icon to its left, shouldn't be "not responding" R=mark@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/45253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231108 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/plugin/chrome_content_plugin_client.cc | 25 ------------------------- chrome/plugin/chrome_content_plugin_client.h | 1 - 2 files changed, 26 deletions(-) (limited to 'chrome/plugin') diff --git a/chrome/plugin/chrome_content_plugin_client.cc b/chrome/plugin/chrome_content_plugin_client.cc index f9f8f0c..4e1dee7d 100644 --- a/chrome/plugin/chrome_content_plugin_client.cc +++ b/chrome/plugin/chrome_content_plugin_client.cc @@ -17,14 +17,6 @@ #endif #endif -#if defined(OS_MACOSX) -#include "base/mac/mac_util.h" -#include "base/mac/scoped_cftyperef.h" -#include "base/strings/sys_string_conversions.h" -#include "grit/chromium_strings.h" -#include "ui/base/l10n/l10n_util.h" -#endif - namespace chrome { void ChromeContentPluginClient::PreSandboxInitialization() { @@ -52,21 +44,4 @@ void ChromeContentPluginClient::PreSandboxInitialization() { #endif // defined(ENABLE_REMOTING) } -void ChromeContentPluginClient::PluginProcessStarted( - const string16& plugin_name) { -#if defined(OS_MACOSX) - base::ScopedCFTypeRef cf_plugin_name( - base::SysUTF16ToCFStringRef(plugin_name)); - base::ScopedCFTypeRef app_name(base::SysUTF16ToCFStringRef( - l10n_util::GetStringUTF16(IDS_SHORT_PLUGIN_APP_NAME))); - base::ScopedCFTypeRef process_name( - CFStringCreateWithFormat(kCFAllocatorDefault, - NULL, - CFSTR("%@ (%@)"), - cf_plugin_name.get(), - app_name.get())); - base::mac::SetProcessName(process_name); -#endif -} - } // namespace chrome diff --git a/chrome/plugin/chrome_content_plugin_client.h b/chrome/plugin/chrome_content_plugin_client.h index 0392102..0d224f6 100644 --- a/chrome/plugin/chrome_content_plugin_client.h +++ b/chrome/plugin/chrome_content_plugin_client.h @@ -13,7 +13,6 @@ namespace chrome { class ChromeContentPluginClient : public content::ContentPluginClient { public: virtual void PreSandboxInitialization() OVERRIDE; - virtual void PluginProcessStarted(const string16& plugin_name) OVERRIDE; }; } // namespace chrome -- cgit v1.1