From 1ce7a71f486279fcd7186783058d82167d885b19 Mon Sep 17 00:00:00 2001 From: "mark@chromium.org" Date: Tue, 14 Jun 2011 20:07:12 +0000 Subject: Use base::win::GetVersion for Windows run-time version checks in preference to base::SysInfo::OperatingSystemVersionNumbers. The latter is just a harder-to-use wrapper around the former. BUG=86062 TEST=none Review URL: http://codereview.chromium.org/7150018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89055 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/renderer/localized_error.cc | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) (limited to 'chrome/renderer/localized_error.cc') diff --git a/chrome/renderer/localized_error.cc b/chrome/renderer/localized_error.cc index ac63d49..3476505 100644 --- a/chrome/renderer/localized_error.cc +++ b/chrome/renderer/localized_error.cc @@ -8,7 +8,6 @@ #include "base/logging.h" #include "base/string16.h" #include "base/string_number_conversions.h" -#include "base/sys_info.h" #include "base/utf_string_conversions.h" #include "base/values.h" #include "chrome/common/extensions/extension_set.h" @@ -21,6 +20,10 @@ #include "ui/base/l10n/l10n_util.h" #include "webkit/glue/webkit_glue.h" +#if defined(OS_WIN) +#include "base/win/windows_version.h" +#endif + using WebKit::WebURLError; namespace { @@ -442,14 +445,12 @@ void LocalizedError::GetStrings(const WebKit::WebURLError& error, IDS_ERRORPAGES_SUMMARY_INTERNET_DISCONNECTED_PLATFORM; #if defined(OS_WIN) // Different versions of Windows have different instructions. - int32 major_version, minor_version, bugfix_version; - base::SysInfo::OperatingSystemVersionNumbers( - &major_version, &minor_version, &bugfix_version); - if (major_version < 6) { + base::win::Version windows_version = base::win::GetVersion(); + if (windows_version < base::win::VERSION_VISTA) { // XP, XP64, and Server 2003. platform_string_id = IDS_ERRORPAGES_SUMMARY_INTERNET_DISCONNECTED_PLATFORM_XP; - } else if (major_version == 6 && minor_version == 0) { + } else if (windows_version == base::win::VERSION_VISTA) { // Vista platform_string_id = IDS_ERRORPAGES_SUMMARY_INTERNET_DISCONNECTED_PLATFORM_VISTA; -- cgit v1.1