From d454745055f7ec8c6b5fc158c61f66452d39aabf Mon Sep 17 00:00:00 2001 From: "erg@google.com" Date: Thu, 28 Aug 2008 18:36:37 +0000 Subject: The GetWindowRect must return the rect of the container HWND; not the actual window rect. The usage of GetWindowRect in the ChromeClientImpl::windowRect() function is erroneous, and my modification of GetWindowRect to return the HWND's root ancestor rect broke drop down combo boxes and other embeded controls. So instead, add a GetRootWindowRect which gets the root anncestor of the HWND's rect and use it in ChromeClientImpl::windowRect(). BUG=1344367,1186573,1334505 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1496 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/renderer/render_widget.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'chrome/renderer/render_widget.h') diff --git a/chrome/renderer/render_widget.h b/chrome/renderer/render_widget.h index 1d27677..ea1e4f7e 100644 --- a/chrome/renderer/render_widget.h +++ b/chrome/renderer/render_widget.h @@ -67,6 +67,7 @@ class RenderWidget : public IPC::Channel::Listener, virtual void Blur(WebWidget* webwidget); virtual void GetWindowRect(WebWidget* webwidget, gfx::Rect* rect); virtual void SetWindowRect(WebWidget* webwidget, const gfx::Rect& rect); + virtual void GetRootWindowRect(WebWidget* webwidget, gfx::Rect* rect); virtual void DidMove(WebWidget* webwidget, const WebPluginGeometry& move); virtual void RunModal(WebWidget* webwidget) {} @@ -255,4 +256,3 @@ class RenderWidget : public IPC::Channel::Listener, }; #endif // CHROME_RENDERER_RENDER_WIDGET_H__ - -- cgit v1.1