From b8aacbe5510e9a7aaccb5646904f350bca8e3a7c Mon Sep 17 00:00:00 2001 From: vmpstr Date: Thu, 25 Feb 2016 18:00:48 -0800 Subject: chrome: Add out-of-line copy ctors for complex classes. This patch adds out of line copy constructors for classes that our clang-plugin considers heavy. This is an effort to enable copy constructor checks by default. BUG=436357 R=dcheng@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/1731483003 Cr-Commit-Position: refs/heads/master@{#377767} --- chrome/renderer/media/cast_rtp_stream.cc | 5 +++++ chrome/renderer/media/cast_rtp_stream.h | 2 ++ chrome/renderer/media/cast_transport_sender_ipc.cc | 2 ++ chrome/renderer/media/cast_transport_sender_ipc.h | 1 + chrome/renderer/plugins/power_saver_info.cc | 2 ++ chrome/renderer/plugins/power_saver_info.h | 1 + 6 files changed, 13 insertions(+) (limited to 'chrome/renderer') diff --git a/chrome/renderer/media/cast_rtp_stream.cc b/chrome/renderer/media/cast_rtp_stream.cc index 9fe4f0a..d102407 100644 --- a/chrome/renderer/media/cast_rtp_stream.cc +++ b/chrome/renderer/media/cast_rtp_stream.cc @@ -512,10 +512,15 @@ CastRtpPayloadParams::CastRtpPayloadParams() max_frame_rate(0.0) { } +CastRtpPayloadParams::CastRtpPayloadParams(const CastRtpPayloadParams& other) = + default; + CastRtpPayloadParams::~CastRtpPayloadParams() {} CastRtpParams::CastRtpParams() {} +CastRtpParams::CastRtpParams(const CastRtpParams& other) = default; + CastRtpParams::~CastRtpParams() {} CastRtpStream::CastRtpStream(const blink::WebMediaStreamTrack& track, diff --git a/chrome/renderer/media/cast_rtp_stream.h b/chrome/renderer/media/cast_rtp_stream.h index dd8c0c3..994898d 100644 --- a/chrome/renderer/media/cast_rtp_stream.h +++ b/chrome/renderer/media/cast_rtp_stream.h @@ -86,6 +86,7 @@ struct CastRtpPayloadParams { std::vector codec_specific_params; CastRtpPayloadParams(); + CastRtpPayloadParams(const CastRtpPayloadParams& other); ~CastRtpPayloadParams(); }; @@ -100,6 +101,7 @@ struct CastRtpParams { std::vector rtcp_features; CastRtpParams(); + CastRtpParams(const CastRtpParams& other); ~CastRtpParams(); }; diff --git a/chrome/renderer/media/cast_transport_sender_ipc.cc b/chrome/renderer/media/cast_transport_sender_ipc.cc index da614b8..03f3ca8 100644 --- a/chrome/renderer/media/cast_transport_sender_ipc.cc +++ b/chrome/renderer/media/cast_transport_sender_ipc.cc @@ -14,6 +14,8 @@ #include "media/cast/cast_sender.h" CastTransportSenderIPC::ClientCallbacks::ClientCallbacks() {} +CastTransportSenderIPC::ClientCallbacks::ClientCallbacks( + const ClientCallbacks& other) = default; CastTransportSenderIPC::ClientCallbacks::~ClientCallbacks() {} CastTransportSenderIPC::CastTransportSenderIPC( diff --git a/chrome/renderer/media/cast_transport_sender_ipc.h b/chrome/renderer/media/cast_transport_sender_ipc.h index 2903d31..d8bcc11 100644 --- a/chrome/renderer/media/cast_transport_sender_ipc.h +++ b/chrome/renderer/media/cast_transport_sender_ipc.h @@ -76,6 +76,7 @@ class CastTransportSenderIPC private: struct ClientCallbacks { ClientCallbacks(); + ClientCallbacks(const ClientCallbacks& other); ~ClientCallbacks(); media::cast::RtcpCastMessageCallback cast_message_cb; diff --git a/chrome/renderer/plugins/power_saver_info.cc b/chrome/renderer/plugins/power_saver_info.cc index 199b66a..c54ed8c 100644 --- a/chrome/renderer/plugins/power_saver_info.cc +++ b/chrome/renderer/plugins/power_saver_info.cc @@ -73,6 +73,8 @@ std::string GetPluginInstancePosterAttribute( PowerSaverInfo::PowerSaverInfo() : power_saver_enabled(false), blocked_for_background_tab(false) {} +PowerSaverInfo::PowerSaverInfo(const PowerSaverInfo& other) = default; + PowerSaverInfo PowerSaverInfo::Get(content::RenderFrame* render_frame, bool power_saver_setting_on, const blink::WebPluginParams& params, diff --git a/chrome/renderer/plugins/power_saver_info.h b/chrome/renderer/plugins/power_saver_info.h index 7da43e6..ec1c5de 100644 --- a/chrome/renderer/plugins/power_saver_info.h +++ b/chrome/renderer/plugins/power_saver_info.h @@ -23,6 +23,7 @@ struct WebPluginInfo; // The default constructor has Plugin Power Saver disabled. struct PowerSaverInfo { PowerSaverInfo(); + PowerSaverInfo(const PowerSaverInfo& other); // Determines the PowerSaverInfo using the peripheral content heuristic. static PowerSaverInfo Get(content::RenderFrame* render_frame, -- cgit v1.1