From d7b6c6eab52e6a2054d4e786e31b7bb662c10615 Mon Sep 17 00:00:00 2001 From: "fsamuel@chromium.org" Date: Fri, 10 Jan 2014 22:46:14 +0000 Subject: : Fix Javascript error on attributeChanged callback Modifying attributes on webview prior to attaching the internal_ to would throw a javascript error. This CL addresses this. BUG=333302 Review URL: https://codereview.chromium.org/134393002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244270 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/renderer/resources/extensions/web_view.js | 3 +++ 1 file changed, 3 insertions(+) (limited to 'chrome/renderer') diff --git a/chrome/renderer/resources/extensions/web_view.js b/chrome/renderer/resources/extensions/web_view.js index f9db94f..f8ae2cb 100644 --- a/chrome/renderer/resources/extensions/web_view.js +++ b/chrome/renderer/resources/extensions/web_view.js @@ -958,6 +958,9 @@ function registerWebViewElement() { }; proto.attributeChangedCallback = function(name, oldValue, newValue) { + if (!this.internal_) { + return; + } var internal = this.internal_(secret); internal.handleWebviewAttributeMutation_(name, oldValue, newValue); }; -- cgit v1.1