From d8f8a5949f1e5cd15058ade51296ca620d456736 Mon Sep 17 00:00:00 2001
From: "darin@chromium.org"
 <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Thu, 9 Jul 2009 18:55:20 +0000
Subject: Remove reference counting from WebWidgetDelegate.

This was added as a speculative crash fix by eseidel back in June of 2008.  See
http://b/1211911 for details.  It didn't appear to resolve the crash then (as
another patch was required to fix the bug), and it doesn't seem to be necessary
since the RenderView, which is the delegate and owns the WebView, is the one in
charge of allocating the WebView and destroying the WebView.  So, it is not
possible for the WebView to outlive the RenderView.

BUG=16234
TEST=none
R=brettw

Review URL: http://codereview.chromium.org/155292

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20294 0039d316-1c4b-4281-b951-d872f2087c98
---
 chrome/renderer/render_view.h   | 7 +------
 chrome/renderer/render_widget.h | 8 --------
 2 files changed, 1 insertion(+), 14 deletions(-)

(limited to 'chrome/renderer')

diff --git a/chrome/renderer/render_view.h b/chrome/renderer/render_view.h
index 49eb26d..bc44ac9 100644
--- a/chrome/renderer/render_view.h
+++ b/chrome/renderer/render_view.h
@@ -49,17 +49,12 @@ class FilePath;
 class GURL;
 class NavigationState;
 class PrintWebViewHelper;
-class RenderThread;
-class ResourceDispatcher;
 class WebFrame;
 class WebPluginDelegate;
 class WebPluginDelegateProxy;
 class WebDevToolsAgentDelegate;
-struct FindInPageRequest;
 struct ThumbnailScore;
 struct ViewMsg_Navigate_Params;
-struct ViewMsg_PrintPage_Params;
-struct ViewMsg_Print_Params;
 struct ViewMsg_UploadFile_Params;
 struct WebDropData;
 
@@ -73,9 +68,9 @@ struct FileUploadData;
 
 namespace WebKit {
 class WebDragData;
-struct WebFindOptions;
 class WebMediaPlayer;
 class WebMediaPlayerClient;
+struct WebFindOptions;
 }
 
 // We need to prevent a page from trying to create infinite popups. It is not
diff --git a/chrome/renderer/render_widget.h b/chrome/renderer/render_widget.h
index 4c5b17c..3be99d8 100644
--- a/chrome/renderer/render_widget.h
+++ b/chrome/renderer/render_widget.h
@@ -51,14 +51,6 @@ class RenderWidget : public IPC::Channel::Listener,
     return webwidget_;
   }
 
-  // Implementing RefCounting required for WebWidgetDelegate
-  virtual void AddRef() {
-    base::RefCounted<RenderWidget>::AddRef();
-  }
-  virtual void Release() {
-    base::RefCounted<RenderWidget>::Release();
-  }
-
   // IPC::Channel::Listener
   virtual void OnMessageReceived(const IPC::Message& msg);
 
-- 
cgit v1.1