From c611e5e6c1cdc270981f6e96f7f5ccf052032440 Mon Sep 17 00:00:00 2001 From: "gene@chromium.org" Date: Thu, 13 Oct 2011 21:29:53 +0000 Subject: Fixed issues with Cloud Print proxy. Currently, we are clearing waiting_for_reply_ ONLY on handled messages. Previously, we cleared waiting_for_reply_ on ANY message. Because message was forwarded to a different thread, and flag was cleared irrespective of message handling. BUG=none TEST=Verify CloudPrint proxy works. Review URL: http://codereview.chromium.org/8252002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105375 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/service/service_utility_process_host.h | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) (limited to 'chrome/service/service_utility_process_host.h') diff --git a/chrome/service/service_utility_process_host.h b/chrome/service/service_utility_process_host.h index df9fc42..59f13d7 100644 --- a/chrome/service/service_utility_process_host.h +++ b/chrome/service/service_utility_process_host.h @@ -81,7 +81,6 @@ class ServiceUtilityProcessHost : public ServiceChildProcessHost { friend class base::RefCountedThreadSafe; friend class ServiceUtilityProcessHost; - bool OnMessageReceived(const IPC::Message& message); // Invoked when a metafile file is ready. void MetafileAvailable(const FilePath& metafile_path, int highest_rendered_page_number); @@ -126,8 +125,16 @@ class ServiceUtilityProcessHost : public ServiceChildProcessHost { // Called when at least one page in the specified PDF has been rendered // successfully into metafile_path_; void OnRenderPDFPagesToMetafileSucceeded(int highest_rendered_page_number); - // Any other messages to be handled by the client. - bool MessageForClient(const IPC::Message& message); + // Called when PDF rendering failed. + void OnRenderPDFPagesToMetafileFailed(); + // Called when the printer capabilities and defaults have been + // retrieved successfully. + void OnGetPrinterCapsAndDefaultsSucceeded( + const std::string& printer_name, + const printing::PrinterCapsAndDefaults& caps_and_defaults); + // Called when the printer capabilities and defaults could not be + // retrieved successfully. + void OnGetPrinterCapsAndDefaultsFailed(const std::string& printer_name); #if defined(OS_WIN) // This hack is Windows-specific. void OnPreCacheFont(const LOGFONT& font); -- cgit v1.1