From 48329f9991ee2acf562abdd28e41c5597dc2c066 Mon Sep 17 00:00:00 2001 From: "jhawkins@chromium.org" Date: Mon, 28 Mar 2011 19:38:22 +0000 Subject: Coverity: Pass parameters by reference. CID=6820,8735,11066,11067,11070,11071,11072,11073,11215,11216,11217,11927,12403 BUG=none TEST=none R=csilv@chromium.org Review URL: http://codereview.chromium.org/6730040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79602 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/service/cloud_print/cloud_print_proxy_backend.cc | 6 +++--- chrome/service/cloud_print/cloud_print_proxy_backend.h | 8 ++++---- chrome/service/service_utility_process_host.cc | 2 +- chrome/service/service_utility_process_host.h | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) (limited to 'chrome/service') diff --git a/chrome/service/cloud_print/cloud_print_proxy_backend.cc b/chrome/service/cloud_print/cloud_print_proxy_backend.cc index b641d35..cbf55ee 100644 --- a/chrome/service/cloud_print/cloud_print_proxy_backend.cc +++ b/chrome/service/cloud_print/cloud_print_proxy_backend.cc @@ -258,9 +258,9 @@ bool CloudPrintProxyBackend::InitializeWithLsid(const std::string& lsid, } bool CloudPrintProxyBackend::InitializeWithToken( - const std::string cloud_print_token, - const std::string cloud_print_xmpp_token, - const std::string email, + const std::string& cloud_print_token, + const std::string& cloud_print_xmpp_token, + const std::string& email, const std::string& proxy_id) { if (!core_thread_.Start()) return false; diff --git a/chrome/service/cloud_print/cloud_print_proxy_backend.h b/chrome/service/cloud_print/cloud_print_proxy_backend.h index 2a6b3df..aa0328d 100644 --- a/chrome/service/cloud_print/cloud_print_proxy_backend.h +++ b/chrome/service/cloud_print/cloud_print_proxy_backend.h @@ -1,4 +1,4 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -55,9 +55,9 @@ class CloudPrintProxyBackend { ~CloudPrintProxyBackend(); bool InitializeWithLsid(const std::string& lsid, const std::string& proxy_id); - bool InitializeWithToken(const std::string cloud_print_token, - const std::string cloud_print_xmpp_token, - const std::string email, + bool InitializeWithToken(const std::string& cloud_print_token, + const std::string& cloud_print_xmpp_token, + const std::string& email, const std::string& proxy_id); void Shutdown(); void RegisterPrinters(const printing::PrinterList& printer_list); diff --git a/chrome/service/service_utility_process_host.cc b/chrome/service/service_utility_process_host.cc index fd86652..a49e434 100644 --- a/chrome/service/service_utility_process_host.cc +++ b/chrome/service/service_utility_process_host.cc @@ -157,7 +157,7 @@ bool ServiceUtilityProcessHost::MessageForClient(const IPC::Message& message) { } #if defined(OS_WIN) // This hack is Windows-specific. -void ServiceUtilityProcessHost::OnPreCacheFont(LOGFONT font) { +void ServiceUtilityProcessHost::OnPreCacheFont(const LOGFONT& font) { PreCacheFont(font); } #endif // OS_WIN diff --git a/chrome/service/service_utility_process_host.h b/chrome/service/service_utility_process_host.h index d9d9907..b3802f9 100644 --- a/chrome/service/service_utility_process_host.h +++ b/chrome/service/service_utility_process_host.h @@ -130,7 +130,7 @@ class ServiceUtilityProcessHost : public ServiceChildProcessHost { bool MessageForClient(const IPC::Message& message); #if defined(OS_WIN) // This hack is Windows-specific. - void OnPreCacheFont(LOGFONT font); + void OnPreCacheFont(const LOGFONT& font); #endif // defined(OS_WIN) // A pointer to our client interface, who will be informed of progress. -- cgit v1.1