From 6dbd362e4fe80afa82b7b3a060642a1d8b513a35 Mon Sep 17 00:00:00 2001 From: "kbr@chromium.org" Date: Tue, 28 Dec 2010 17:40:17 +0000 Subject: Mark CloudPrintURLFetcherBasicTest.HandleRawResponse FLAKY because of intermittent failures on Mac. Update comments for HandleRawData and GiveUp to point at bug 60426 rather than bug 62758. BUG=60426 TEST=none TBR=sanjeevr Review URL: http://codereview.chromium.org/6018009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70227 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'chrome/service') diff --git a/chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc b/chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc index 8a393fd..d02b7aa 100644 --- a/chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc +++ b/chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc @@ -291,7 +291,8 @@ void CloudPrintURLFetcherRetryBackoffTest::OnRequestGiveUp() { io_message_loop_proxy()->PostTask(FROM_HERE, new MessageLoop::QuitTask()); } -TEST_F(CloudPrintURLFetcherBasicTest, HandleRawResponse) { +// http://code.google.com/p/chromium/issues/detail?id=60426 +TEST_F(CloudPrintURLFetcherBasicTest, FLAKY_HandleRawResponse) { net::TestServer test_server(net::TestServer::TYPE_HTTP, FilePath(kDocRoot)); ASSERT_TRUE(test_server.Start()); SetHandleRawResponse(true); @@ -300,7 +301,7 @@ TEST_F(CloudPrintURLFetcherBasicTest, HandleRawResponse) { MessageLoop::current()->Run(); } -// http://code.google.com/p/chromium/issues/detail?id=62758 +// http://code.google.com/p/chromium/issues/detail?id=60426 TEST_F(CloudPrintURLFetcherBasicTest, FLAKY_HandleRawData) { net::TestServer test_server(net::TestServer::TYPE_HTTP, FilePath(kDocRoot)); ASSERT_TRUE(test_server.Start()); @@ -330,7 +331,7 @@ TEST_F(CloudPrintURLFetcherOverloadTest, Protect) { net::URLRequestThrottlerManager::GetInstance()->EraseEntryForTests(url); } -// http://code.google.com/p/chromium/issues/detail?id=62758 +// http://code.google.com/p/chromium/issues/detail?id=60426 TEST_F(CloudPrintURLFetcherRetryBackoffTest, FLAKY_GiveUp) { net::TestServer test_server(net::TestServer::TYPE_HTTP, FilePath(kDocRoot)); ASSERT_TRUE(test_server.Start()); -- cgit v1.1