From 9c9c761a2e070a8a6eb00f22a4365fc6cc2e1eff Mon Sep 17 00:00:00 2001 From: "erg@chromium.org" Date: Tue, 16 Jun 2009 17:05:11 +0000 Subject: Removes entirely dead code paths related to ConstrainedWindows. - Removes parts of the interface that probably made sense at some time, but now only have a DLOG(INFO) as their implementation. Also remove their callers. - Remove all usage of the ConstrainedWindowProxy interface in the automation system. It was *never* used. - Rename constrianed_window_impl_interactive_uitests.cc to blocked_popup_container_interactive_uitest.cc. The test case hasn't tested code in constrained_window_impl.cc since the rewrite of the blocked popup system back last autumn. Review URL: http://codereview.chromium.org/125160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18498 0039d316-1c4b-4281-b951-d872f2087c98 --- .../test/automation/automation_messages_internal.h | 24 ---------------------- 1 file changed, 24 deletions(-) mode change 100755 => 100644 chrome/test/automation/automation_messages_internal.h (limited to 'chrome/test/automation/automation_messages_internal.h') diff --git a/chrome/test/automation/automation_messages_internal.h b/chrome/test/automation/automation_messages_internal.h old mode 100755 new mode 100644 index 91961cf..4367a46 --- a/chrome/test/automation/automation_messages_internal.h +++ b/chrome/test/automation/automation_messages_internal.h @@ -244,22 +244,6 @@ IPC_BEGIN_MESSAGES(Automation) int /* tab_handle */, int /* constrained_window_count */) - // This message requests the handle of the constrained window with the given - // (zero-based) index in the given tab. First parameter specifies the given - // tab handle, second specifies the given child_index. On error, the returned - // handle value is 0. - IPC_SYNC_MESSAGE_ROUTED2_1(AutomationMsg_ConstrainedWindow, - int, /* window_handle */ - int, /* child_index */ - int) /* constrained_handle */ - - // This message requests the the title of the constrained window with the - // given handle. The return value contains the size of the title string and - // title string. On error, this value should be -1 and empty string. Note - // that the title can be empty in which case the size would be 0. - IPC_SYNC_MESSAGE_ROUTED1_2(AutomationMsg_ConstrainedTitle, int, - int, std::wstring) - // This message requests the bounds of the specified View element in // window coordinates. // Request: @@ -667,14 +651,6 @@ IPC_BEGIN_MESSAGES(Automation) // exist. IPC_SYNC_MESSAGE_ROUTED0_1(AutomationMsg_LastActiveBrowserWindow, int) - // This message requests the bounds of a constrained window (relative to its - // containing TabContents). On an internal error, the boolean in the result - // will be set to false. - IPC_SYNC_MESSAGE_ROUTED1_2(AutomationMsg_ConstrainedWindowBounds, - int /* tab_handle */, - bool /* the requested window exists */, - gfx::Rect /* constrained_window_count */) - // This message notifies the AutomationProvider to save the page with given // handle. The first parameter is the handle to the tab resource. The second // parameter is the main HTML file name. The third parameter is the directory -- cgit v1.1