From f1d306e67b8676336f55aae95652d7cd51359534 Mon Sep 17 00:00:00 2001 From: "pkasting@chromium.org" Date: Mon, 8 Dec 2008 20:50:05 +0000 Subject: Cleanup, part 1. * Consistently use underscores between words in identifiers (IDC_NEWTAB -> IDC_NEW_TAB) * Make some identifiers clearer or more up-to-date (IDC_DUPLICATE -> IDC_DUPLICATE_TAB, IDC_GOOFFTHERECORD -> IDC_NEW_INCOGNITO_WINDOW, IDC_NEWPROFILEWINDOW -> IDC_PROFILE_MENU) * Try and make string identifiers (IDS_xxx) match their corresponding IDC_xxx commands. Tony tells me this will not cause any need for retranslation. * As much as possible (without modifying automated UI test XML files), use "Bookmark Bar", not "Bookmarks Bar" (this seemed to be prevailing usage in the code) * Fix 80-column issues This patch touches move files than any subsequent patches, but should be the most rubber-stampable. Review URL: http://codereview.chromium.org/13633 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6535 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/test/automation/automation_proxy_uitest.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'chrome/test/automation') diff --git a/chrome/test/automation/automation_proxy_uitest.cc b/chrome/test/automation/automation_proxy_uitest.cc index ece5fd8..4a0cd90 100644 --- a/chrome/test/automation/automation_proxy_uitest.cc +++ b/chrome/test/automation/automation_proxy_uitest.cc @@ -476,7 +476,7 @@ TEST_F(AutomationProxyTest, AcceleratorNewTab) { int old_tab_count = -1; ASSERT_TRUE(window->GetTabCount(&old_tab_count)); - ASSERT_TRUE(window->ApplyAccelerator(IDC_NEWTAB)); + ASSERT_TRUE(window->ApplyAccelerator(IDC_NEW_TAB)); int new_tab_count; ASSERT_TRUE(window->WaitForTabCountToChange(old_tab_count, &new_tab_count, 5000)); @@ -785,7 +785,7 @@ TEST_F(AutomationProxyTest, AutocompleteParallelProxy) { scoped_ptr edit1( automation()->GetAutocompleteEditForBrowser(browser1.get())); ASSERT_TRUE(edit1.get()); - EXPECT_TRUE(browser1->ApplyAccelerator(IDC_NEWWINDOW)); + EXPECT_TRUE(browser1->ApplyAccelerator(IDC_NEW_WINDOW)); scoped_ptr browser2(automation()->GetBrowserWindow(1)); ASSERT_TRUE(browser2.get()); scoped_ptr edit2( -- cgit v1.1