From 34828570d298a402b6964cdfa99521c74c507faa Mon Sep 17 00:00:00 2001 From: tsergeant Date: Wed, 9 Mar 2016 22:20:44 -0800 Subject: Revert of Use v8::MicrotasksScope internally in V8RecursionScope. (patchset #6 id:100001 of https://codereview.chromium.org/1743763004/ ) Reason for revert: This CL appears to be causing test failures on Linux ChromiumOS Tests (dbg)(1). See: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/12424 Tests are failing with: Fatal error in ../../v8/src/api.cc, line 166 Check failed: handle_scope_implementer->GetMicrotasksScopeDepth() || !handle_scope_implementer->DebugMicrotasksScopeDepthIsZero() Original issue's description: > Use v8::MicrotasksScope internally in V8RecursionScope. > > If this sticks we can just remove V8RecursionScope and WebScopedMicrotaskSuppression, > along with other cleanups. > > Attempt #2. Previous one broke GinJavaBridgeValueConverterTest.TypedArrays. > > BUG=585949 > > Committed: https://crrev.com/95a3bd544fe93629b209797d3251423f3d674463 > Cr-Commit-Position: refs/heads/master@{#380033} TBR=jochen@chromium.org,adamk@chromium.org,dgozman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=585949 Review URL: https://codereview.chromium.org/1777183002 Cr-Commit-Position: refs/heads/master@{#380356} --- chrome/test/base/v8_unit_test.cc | 4 ---- 1 file changed, 4 deletions(-) (limited to 'chrome/test/base/v8_unit_test.cc') diff --git a/chrome/test/base/v8_unit_test.cc b/chrome/test/base/v8_unit_test.cc index 392ff45..9f52f06 100644 --- a/chrome/test/base/v8_unit_test.cc +++ b/chrome/test/base/v8_unit_test.cc @@ -11,7 +11,6 @@ #include "base/strings/stringprintf.h" #include "chrome/common/chrome_paths.h" #include "third_party/WebKit/public/web/WebKit.h" -#include "third_party/WebKit/public/web/WebScopedMicrotaskSuppression.h" namespace { @@ -96,7 +95,6 @@ bool V8UnitTest::RunJavascriptTestF(const std::string& test_fixture, v8::Local context = v8::Local::New(isolate, context_); v8::Context::Scope context_scope(context); - blink::WebScopedMicrotaskSuppression microtasks_scope; v8::Local function_property = context->Global()->Get(v8::String::NewFromUtf8(isolate, "runTest")); @@ -211,7 +209,6 @@ void V8UnitTest::ExecuteScriptInContext(const base::StringPiece& script_source, v8::Local context = v8::Local::New(isolate, context_); v8::Context::Scope context_scope(context); - blink::WebScopedMicrotaskSuppression microtasks_scope; v8::Local source = v8::String::NewFromUtf8(isolate, script_source.data(), @@ -260,7 +257,6 @@ void V8UnitTest::TestFunction(const std::string& function_name) { v8::Local context = v8::Local::New(isolate, context_); v8::Context::Scope context_scope(context); - blink::WebScopedMicrotaskSuppression microtasks_scope; v8::Local function_property = context->Global()->Get( v8::String::NewFromUtf8(isolate, function_name.c_str())); -- cgit v1.1