From 72f8ea4b1f412c3f5d842bfd39f2912a941c6958 Mon Sep 17 00:00:00 2001 From: "jvoung@chromium.org" Date: Sat, 20 Jul 2013 06:36:38 +0000 Subject: Change PNaCl NMF parser to accept "optlevel" instead of "-O" and change default. Change default optlevel from 0 to "unknown" (which is actually the pnacl-llc default aka -O2). Change key from "-O" to "optlevel". This makes the NMF file look less like it's specifying commandline flags and doesn't stick out as much. Also, emit an error which tells people what to change, if a legacy NMF file is encountered. BUG=http://code.google.com/p/nativeclient/issues/detail?id=3553 Review URL: https://chromiumcodereview.appspot.com/19851002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212768 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/test/data/nacl/pnacl_nmf_options/pnacl_o_0.nmf | 2 +- chrome/test/data/nacl/pnacl_nmf_options/pnacl_o_2.nmf | 2 +- chrome/test/data/nacl/pnacl_nmf_options/pnacl_o_large.nmf | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) (limited to 'chrome/test/data') diff --git a/chrome/test/data/nacl/pnacl_nmf_options/pnacl_o_0.nmf b/chrome/test/data/nacl/pnacl_nmf_options/pnacl_o_0.nmf index d8c6e4a..e1322bb 100644 --- a/chrome/test/data/nacl/pnacl_nmf_options/pnacl_o_0.nmf +++ b/chrome/test/data/nacl/pnacl_nmf_options/pnacl_o_0.nmf @@ -2,7 +2,7 @@ "program": { "portable": { "pnacl-translate": { - "-O": 0, + "optlevel": 0, "url": "pnacl_options_newlib_pnacl.pexe" } } diff --git a/chrome/test/data/nacl/pnacl_nmf_options/pnacl_o_2.nmf b/chrome/test/data/nacl/pnacl_nmf_options/pnacl_o_2.nmf index 59d8c34..650983e 100644 --- a/chrome/test/data/nacl/pnacl_nmf_options/pnacl_o_2.nmf +++ b/chrome/test/data/nacl/pnacl_nmf_options/pnacl_o_2.nmf @@ -2,7 +2,7 @@ "program": { "portable": { "pnacl-translate": { - "-O": 2, + "optlevel": 2, "url": "pnacl_options_newlib_pnacl.pexe" } } diff --git a/chrome/test/data/nacl/pnacl_nmf_options/pnacl_o_large.nmf b/chrome/test/data/nacl/pnacl_nmf_options/pnacl_o_large.nmf index 9dfb0c6..65cf918 100644 --- a/chrome/test/data/nacl/pnacl_nmf_options/pnacl_o_large.nmf +++ b/chrome/test/data/nacl/pnacl_nmf_options/pnacl_o_large.nmf @@ -2,7 +2,7 @@ "program": { "portable": { "pnacl-translate": { - "-O": 257, + "optlevel": 257, "url": "pnacl_options_newlib_pnacl.pexe" } } -- cgit v1.1