From d878bab389753cb876231717217a7e470b5a261f Mon Sep 17 00:00:00 2001 From: "ojan@google.com" Date: Thu, 6 Nov 2008 01:18:56 +0000 Subject: Bandaid patch so that we continue with crosssite navigations instead of closing the tab if the beforeunload /unload handler hangs. This patch does the right user-visible behavior, but I'm not a huge fan of the plumbing necessary to make it work. Totally open to cleanup suggestions. There's also currently one bug that I haven't been able to pinpoint in the UI test. It only treats the first UI test of the four that I run as a cross-site navigation. No matter which test I run first. I wonder if there is some state I should be setting/clearing before/after each test run? Also there's a DHECK that we hit that the UI test exposed. I 'm not sure it's a case that a user could actually hit though and it's not new with this code, so I added a TODO. Can I get help from a mac person on adding the UI test to the xcode project? BUG=3198 Review URL: http://codereview.chromium.org/8920 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4855 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/test/data/unload/beforeunloadlooping.html | 12 ++++++++++++ chrome/test/data/unload/nolisteners.html | 8 +++++++- chrome/test/data/unload/unload.html | 3 +++ chrome/test/data/unload/unloadlooping.html | 3 +++ chrome/test/data/unload/unloadloopingalert.html | 3 +++ chrome/test/data/unload/unloadloopingtwosecondsalert.html | 3 +++ 6 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 chrome/test/data/unload/beforeunloadlooping.html (limited to 'chrome/test/data') diff --git a/chrome/test/data/unload/beforeunloadlooping.html b/chrome/test/data/unload/beforeunloadlooping.html new file mode 100644 index 0000000..ca82c87 --- /dev/null +++ b/chrome/test/data/unload/beforeunloadlooping.html @@ -0,0 +1,12 @@ + + +beforeunloadlooping + + + + + \ No newline at end of file diff --git a/chrome/test/data/unload/nolisteners.html b/chrome/test/data/unload/nolisteners.html index 42682b4..ea59143 100644 --- a/chrome/test/data/unload/nolisteners.html +++ b/chrome/test/data/unload/nolisteners.html @@ -1 +1,7 @@ - \ No newline at end of file + + +nolisteners + + + + \ No newline at end of file diff --git a/chrome/test/data/unload/unload.html b/chrome/test/data/unload/unload.html index 4ce7f78..eb34941 100644 --- a/chrome/test/data/unload/unload.html +++ b/chrome/test/data/unload/unload.html @@ -1,4 +1,7 @@ + +unload +