From a0729671be0628b5d2c45ef9c19a51c53bfa65b5 Mon Sep 17 00:00:00 2001 From: "jcampan@chromium.org" <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Wed, 17 Dec 2008 19:36:52 +0000 Subject: Revamp of the interstitial pages. The interstitial is now a RVH that is displayed on top of the WebContents with no interaction with the WebContents' RenderViewHostManager. This simplifies the states that the RenderViewHostManager has. The interstitial is responsible for hiding and deleting itself when told to proceed/not proceed or when a navigation occurs or the tab is closed. The interstitial now uses a data URL (instead of loading some alternate HTML), which allowed me to remove some interstitial flags from NavigationController::LoadCommittedDetails and ProvisionalLoadDetails. Also changed tab_utils::GetTabContentsByID to return a WebContents since only WebContents have a RVH associated with them. TEST=Run all ui tests and unit tests. Review URL: http://codereview.chromium.org/13764 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7149 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/test/test_tab_contents.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'chrome/test/test_tab_contents.cc') diff --git a/chrome/test/test_tab_contents.cc b/chrome/test/test_tab_contents.cc index 7b43b76..0cb8f54 100644 --- a/chrome/test/test_tab_contents.cc +++ b/chrome/test/test_tab_contents.cc @@ -34,5 +34,5 @@ void TestTabContents::CompleteNavigationAsRenderer(int page_id, params.is_post = false; NavigationController::LoadCommittedDetails details; - controller()->RendererDidNavigate(params, false, &details); + controller()->RendererDidNavigate(params, &details); } -- cgit v1.1