From 18280378d78cc83d8e83de21f28411cb4fa777bc Mon Sep 17 00:00:00 2001 From: "erg@google.com" Date: Tue, 22 Mar 2011 18:05:22 +0000 Subject: Profile shouldn't own BrowserThemeProviders; A ThemeService should and should give back a BTP when presented with a Profile. This removes all Profile methods that deal with themes. A profile is now just the key that ThemeService maps to a BrowserThemeProvider. Any user of a BrowserThemeProvider asks ThemeService::GetForProfile() instead of the now deleted Profile::GetThemeProvider() method. Why do this? Because this will drastically reduce coupling. Right now, the Profile knows about pretty much every major object in chrome/browser/. This should allow easier compile time removal of certain systems. BUG=profile effort TEST=existing tests Review URL: http://codereview.chromium.org/6714003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79001 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/test/testing_profile.h | 10 ---------- 1 file changed, 10 deletions(-) (limited to 'chrome/test/testing_profile.h') diff --git a/chrome/test/testing_profile.h b/chrome/test/testing_profile.h index 7c3ae2bb..befc5a6 100644 --- a/chrome/test/testing_profile.h +++ b/chrome/test/testing_profile.h @@ -185,12 +185,6 @@ class TestingProfile : public Profile { virtual fileapi::FileSystemContext* GetFileSystemContext(); virtual BrowserSignin* GetBrowserSignin(); virtual bool HasCreatedDownloadManager() const; - virtual void InitThemes(); - virtual void SetTheme(const Extension* extension) {} - virtual void SetNativeTheme() {} - virtual void ClearTheme() {} - virtual const Extension* GetTheme(); - virtual BrowserThemeProvider* GetThemeProvider(); // Returns a testing ContextGetter (if one has been created via // CreateRequestContext) or NULL. This is not done on-demand for two reasons: @@ -345,10 +339,6 @@ class TestingProfile : public Profile { // The SessionService. Defaults to NULL, but can be set using the setter. scoped_refptr session_service_; - // The theme provider. Created lazily by GetThemeProvider()/InitThemes(). - scoped_ptr theme_provider_; - bool created_theme_provider_; - // Internally, this is a TestURLRequestContextGetter that creates a dummy // request context. Currently, only the CookieMonster is hooked up. scoped_refptr request_context_; -- cgit v1.1