From c984d9f8b393418f26c8a3a90ceaff17f2d421af Mon Sep 17 00:00:00 2001 From: "atwilson@chromium.org" Date: Tue, 20 Jul 2010 20:52:20 +0000 Subject: Moved code that generates APP_TERMINATING notification into BrowserList so it can be used on all platforms. Updated observers (ExtensionProcessManager, BackgroundContents) to listen for APP_TERMINATING instead of listening for BROWSER_CLOSED on some platforms. APP_TERMINATING is now sent just before the main message loop exits rather than just after, but no code depends on this timing. Updated Mac code to always call BrowserList::CloseAllBrowsers() even if there are no open browsers, to ensure that APP_TERMINATING is always fired. Changed BackgroundContentsService to keep the browser process alive when there are BackgroundContents running and updated the unit tests. Renamed BrowserList::IsInPersistentMode() => WillShutdownWhenLastBrowserCloses() and AllBrowsersClosed() => AllBrowsersClosedAndAppExiting() to more precisely indicate their true functions. Exposed BrowserProcess::ModuleRefCount() so BrowserList can determine when the application is going to exit so the right notifications/callbacks can be generated. Updated background-auto-update-restart code to use new BrowserList APIs to determine whether the application is running "in the background". Added code to cancel shutdown on all plaforms if the user selects cancel in an onbeforeunload dialog. BUG=45275 TEST=RunInBackgroundTest (ui_test) Review URL: http://codereview.chromium.org/2866034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53092 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/test/testing_browser_process.h | 4 ---- 1 file changed, 4 deletions(-) (limited to 'chrome/test') diff --git a/chrome/test/testing_browser_process.h b/chrome/test/testing_browser_process.h index c69af1c..a954e10 100644 --- a/chrome/test/testing_browser_process.h +++ b/chrome/test/testing_browser_process.h @@ -133,10 +133,6 @@ class TestingBrowserProcess : public BrowserProcess { return --module_ref_count_; } - unsigned int module_ref_count() { - return module_ref_count_; - } - virtual bool IsShuttingDown() { return false; } -- cgit v1.1