From 31af2abddfa0c05ee19de5b4646197fa552c7e49 Mon Sep 17 00:00:00 2001 From: "rsesek@chromium.org" Date: Thu, 25 Feb 2010 07:58:17 +0000 Subject: Revert r39951 - Broke Valgrind - "Make sure the workers are given a chance to terminate their thread when the IPC channel fails. Usually, the ChildThread::OnChannelError() simply kills the message loop. we want to give workers an opportunity to get out of their threads to avoid crashes when main thread destroys globals. BUG=35963 TEST=WorkerTest.StressJSExecution Review URL: http://codereview.chromium.org/647064" Revert r39997 - Attempted Fix - "Fix a conditional jump depending on an uninitialized value by setting it to false in the ctor." TBR=dimich BUG=none TEST=Valgrind Review URL: http://codereview.chromium.org/661068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39999 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/worker/webworker_stub.h | 1 - 1 file changed, 1 deletion(-) (limited to 'chrome/worker/webworker_stub.h') diff --git a/chrome/worker/webworker_stub.h b/chrome/worker/webworker_stub.h index dab69d0..59a46f1 100644 --- a/chrome/worker/webworker_stub.h +++ b/chrome/worker/webworker_stub.h @@ -21,7 +21,6 @@ class WebWorkerStub : public WebWorkerStubBase { // IPC::Channel::Listener implementation. virtual void OnMessageReceived(const IPC::Message& message); - virtual void OnChannelError(); private: virtual ~WebWorkerStub(); -- cgit v1.1