From 0520f1a4b181de494c4e1f6d17f6c955f096f223 Mon Sep 17 00:00:00 2001 From: "tc@google.com" Date: Mon, 13 Apr 2009 22:17:02 +0000 Subject: Fix automated_ui_testing for XMLWriter There was an error in InitXMLReader where it tries to delete the bufffer_ member, setting it to null will make it work as mulhern stated. \src\chrome\Debug>automated_ui_tests.exe Started crash_service.exe so you know if a test crashes! [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from AutomatedUITest [ RUN ] AutomatedUITest.TheOneAndOnlyTest .\automated_ui_tests.cc(167): error: Value of: InitXMLReader() Actual: false Expected: true Error initializing XMLReader Then it crashes. TEST=Ran the test again, doesn't crash. BUG=9625 http://crbug.com/9625 Patch by Mohamed Mansour in http://codereview.chromium.org/63001 Review URL: http://codereview.chromium.org/67094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13616 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/common/libxml_utils.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'chrome') diff --git a/chrome/common/libxml_utils.cc b/chrome/common/libxml_utils.cc index f470ce2..dba803b 100644 --- a/chrome/common/libxml_utils.cc +++ b/chrome/common/libxml_utils.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2009 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -120,7 +120,8 @@ bool XmlReader::SkipToElement() { // XmlWriter functions XmlWriter::XmlWriter() : - writer_(NULL) {} + writer_(NULL), + buffer_(NULL) {} XmlWriter::~XmlWriter() { if (writer_) -- cgit v1.1