From 877fa8e72e5998049c190034a5d666cecd098636 Mon Sep 17 00:00:00 2001 From: "thakis@chromium.org" Date: Thu, 29 Jul 2010 17:12:25 +0000 Subject: Mac: Fix broken valgrind suppressions. They don't work locally for me, and on the bots only Mac_Sandbox_Intentional_Leak3 is getting used, which is overly wide. Review URL: http://codereview.chromium.org/2808079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54141 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/common/sandbox_mac_unittest_helper.h | 10 +++++----- chrome/test/data/valgrind/unit_tests.gtest_mac.txt | 2 -- 2 files changed, 5 insertions(+), 7 deletions(-) (limited to 'chrome') diff --git a/chrome/common/sandbox_mac_unittest_helper.h b/chrome/common/sandbox_mac_unittest_helper.h index 3edb7c4..3006576 100644 --- a/chrome/common/sandbox_mac_unittest_helper.h +++ b/chrome/common/sandbox_mac_unittest_helper.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_COMMON_SANDBOX_MAC_UNITTEST_RUNNER_H_ -#define CHROME_COMMON_SANDBOX_MAC_UNITTEST_RUNNER_H_ +#ifndef CHROME_COMMON_SANDBOX_MAC_UNITTEST_HELPER_H_ +#define CHROME_COMMON_SANDBOX_MAC_UNITTEST_HELPER_H_ #pragma once #include "base/multiprocess_test.h" @@ -15,12 +15,12 @@ namespace sandboxtest { // // How to write a sandboxed test: // 1. Create a class that inherits from MacSandboxTestCase and overrides -// it's functions to run code before or after the sandbox is initialised in a +// its functions to run code before or after the sandbox is initialised in a // subprocess. // 2. Register the class you just created with the REGISTER_SANDBOX_TEST_CASE() // macro. // 3. Write a test [using TEST_F()] that inherits from MacSandboxTest and call -// one of it's helper functions to launch the test. +// one of its helper functions to launch the test. // // Example: // class TestCaseThatRunsInSandboxedSubprocess : @@ -114,4 +114,4 @@ template struct RegisterSandboxTest { } // namespace sandboxtest -#endif // CHROME_COMMON_SANDBOX_MAC_UNITTEST_RUNNER_H_ +#endif // CHROME_COMMON_SANDBOX_MAC_UNITTEST_HELPER_H_ diff --git a/chrome/test/data/valgrind/unit_tests.gtest_mac.txt b/chrome/test/data/valgrind/unit_tests.gtest_mac.txt index a013c37..caace66 100644 --- a/chrome/test/data/valgrind/unit_tests.gtest_mac.txt +++ b/chrome/test/data/valgrind/unit_tests.gtest_mac.txt @@ -34,5 +34,3 @@ RenderViewTest.OnPrintPages RenderViewTest.Print* # See http://crbug.com/30397. TabStripControllerTest.AddRemoveTabs -# See http://crbug.com/30398. -TaskManagerWindowControllerTest.* -- cgit v1.1