From 9840dd700990d0f5385e8320719d0fcba3a5c68a Mon Sep 17 00:00:00 2001 From: "rafaelw@chromium.org" Date: Tue, 7 Jul 2009 21:26:42 +0000 Subject: Move extension install to after .crx download completes This was resulting in some situations where we attempted to unpack the .crx while its file was still in use by the download manager. BUG=15881 R=mpcomplete Review URL: http://codereview.chromium.org/149161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20083 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/download/download_manager.cc | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'chrome') diff --git a/chrome/browser/download/download_manager.cc b/chrome/browser/download/download_manager.cc index 7cceb9e..2f3497e 100644 --- a/chrome/browser/download/download_manager.cc +++ b/chrome/browser/download/download_manager.cc @@ -820,8 +820,6 @@ void DownloadManager::DownloadFinished(int32 download_id, int64 size) { void DownloadManager::DownloadRenamedToFinalName(int download_id, const FilePath& full_path) { - if (Extension::IsExtension(full_path)) - OpenChromeExtension(full_path); } void DownloadManager::ContinueDownloadFinished(DownloadItem* download) { @@ -840,8 +838,7 @@ void DownloadManager::ContinueDownloadFinished(DownloadItem* download) { // Handle chrome extensions explicitly and skip the shell execute. if (Extension::IsExtension(download->full_path())) { - // Skip the shell execute. This will be handled in - // DownloadRenamedToFinalName + OpenChromeExtension(download->full_path()); return; } -- cgit v1.1