From b7f2d4ef2b1e8d1b351846e25efbc339d5dcf0bc Mon Sep 17 00:00:00 2001 From: "vabr@chromium.org" Date: Thu, 17 May 2012 22:47:05 +0000 Subject: Removing an unnecessary NOTREACHED() Returning false leads to a NOTREACHED eventually. Also, the two "return false" cases inside ExtensionWebRequestEventRouter::AddEventListener should be treated equally. This is a late tidy-up for CL 10352002. http://codereview.chromium.org/10352002/ BUG=115467 Review URL: https://chromiumcodereview.appspot.com/10392099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137757 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/extensions/api/web_request/web_request_api.cc | 1 - 1 file changed, 1 deletion(-) (limited to 'chrome') diff --git a/chrome/browser/extensions/api/web_request/web_request_api.cc b/chrome/browser/extensions/api/web_request/web_request_api.cc index fa672f1..20616a8 100644 --- a/chrome/browser/extensions/api/web_request/web_request_api.cc +++ b/chrome/browser/extensions/api/web_request/web_request_api.cc @@ -975,7 +975,6 @@ bool ExtensionWebRequestEventRouter::AddEventListener( if (listeners_[profile][event_name].count(listener) != 0u) { // This is likely an abuse of the API by a malicious extension. - NOTREACHED(); return false; } listeners_[profile][event_name].insert(listener); -- cgit v1.1