From e1cbabf62f08b99925618c832ce41c5b6fabbbc8 Mon Sep 17 00:00:00 2001 From: "jrg@chromium.org" Date: Fri, 2 Apr 2010 21:40:24 +0000 Subject: New tab perfbot didn't like this. Reverting to confirm this was the cause. Even if proven the cause my plan is to re-land since this fixes a visible bug but fix perf in a different way. BUG=40225 Revert 43419 - Fix floating bookmark bar on windows. IsBookmarkBarVisible() continues to have a consistent meaning across platforms, but extra logic has been added to windows to be smarter about when to show the bar. Such extra logic also is consistent across platforms (e.g. see browser_window_gtk.cc and bookmark_bar_gtk.cc). Problem introduced with http://codereview.chromium.org/1461001 BUG=http://crbug.com/39559 Review URL: http://codereview.chromium.org/1594009 TBR=jrg@chromium.org Review URL: http://codereview.chromium.org/1539017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43528 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/views/frame/browser_view_layout.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'chrome') diff --git a/chrome/browser/views/frame/browser_view_layout.cc b/chrome/browser/views/frame/browser_view_layout.cc index 562b27c..2b0f2e0 100644 --- a/chrome/browser/views/frame/browser_view_layout.cc +++ b/chrome/browser/views/frame/browser_view_layout.cc @@ -338,8 +338,7 @@ int BrowserViewLayout::LayoutBookmarkAndInfoBars(int top) { int BrowserViewLayout::LayoutBookmarkBar(int top) { DCHECK(active_bookmark_bar_); int y = top; - if (!browser_view_->IsBookmarkBarVisible() && - !active_bookmark_bar_->OnNewTabPage()) { + if (!browser_view_->IsBookmarkBarVisible()) { active_bookmark_bar_->SetVisible(false); active_bookmark_bar_->SetBounds(0, y, browser_view_->width(), 0); return y; -- cgit v1.1