From 2b8fd32897bb674a71f09fd3ec91675b9a627181 Mon Sep 17 00:00:00 2001 From: "ananta@chromium.org" Date: Fri, 2 Oct 2009 00:00:59 +0000 Subject: Fixes the following issue Ensures Alt and Alt + character keys work correctly in ChromeFrame. There were two issues here:- a. Chrome would not forward unhandled Keyup messages. For the curious this carries WM_SYSKEYUP which is needed for Alt key to work. b. WM_SYSCHAR is not handled by the TranslateAccelerator function in IOleControlSite and IBrowserService2::v_MayTranslateAccelerator MSHTML does the same thing and also dispatches the message. We need to understand this better. For now we just post the message back to our parent which works. This fixes http://code.google.com/p/chromium/issues/detail?id=22996 Bug=22996 Review URL: http://codereview.chromium.org/257019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27803 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome_frame/chrome_active_document.cc | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) (limited to 'chrome_frame/chrome_active_document.cc') diff --git a/chrome_frame/chrome_active_document.cc b/chrome_frame/chrome_active_document.cc index ad104c9..dfb1b03 100644 --- a/chrome_frame/chrome_active_document.cc +++ b/chrome_frame/chrome_active_document.cc @@ -399,12 +399,8 @@ void ChromeActiveDocument::OnAcceleratorPressed(int tab_handle, if (IsFindAccelerator(accel_message)) { // Handle the showing of the find dialog explicitly. OnFindInPage(); - } else if (AllowFrameToTranslateAccelerator(accel_message) != S_OK) { - DLOG(INFO) << "IE DID NOT handle accel key " << accel_message.wParam; - TabProxy* tab = GetTabProxy(); - if (tab) { - tab->ProcessUnhandledAccelerator(accel_message); - } + } else { + Base::OnAcceleratorPressed(tab_handle, accel_message); } } else { DLOG(INFO) << "IE handled accel key " << accel_message.wParam; -- cgit v1.1