From e67d0817abcec13b5d4eab730252ef1dfb9ab404 Mon Sep 17 00:00:00 2001 From: "ananta@chromium.org" Date: Wed, 17 Aug 2011 19:22:21 +0000 Subject: Fix a back forward bug in ChromeFrame reported on the field. The bug occurs when multiple navigations are performed within IE + CF with some originating from IE and others within Chrome. The CF active document implementation had some code to reuse the active document instance in case a new CF navigation occurred within the current tab. This was for optimization, i.e. to ensure that we don't tear down and create a new instance of Chrome. This basically messed up the document destruction order causing the IE tab history to get populated with information coming from deleted active document instances at times. In any case this optimization is no longer necessary as we have a proxy cache maintained in the automation client in CF which ensures that we don't inadvarently tear down and create new chrome instances. Fixes bug http://code.google.com/p/chromium/issues/detail?id=90424 BUG=90424 Review URL: http://codereview.chromium.org/7627005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97177 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome_frame/chrome_active_document.h | 2 -- 1 file changed, 2 deletions(-) (limited to 'chrome_frame/chrome_active_document.h') diff --git a/chrome_frame/chrome_active_document.h b/chrome_frame/chrome_active_document.h index 5440528..96232c6 100644 --- a/chrome_frame/chrome_active_document.h +++ b/chrome_frame/chrome_active_document.h @@ -361,8 +361,6 @@ END_EXEC_COMMAND_MAP() protected: // ChromeFrameActivexBase overrides - virtual void OnOpenURL( - const GURL& url_to_open, const GURL& referrer, int open_disposition); virtual void OnAttachExternalTab(const AttachExternalTabParams& params); virtual void OnGoToHistoryEntryOffset(int offset); virtual void OnMoveWindow(const gfx::Rect& dimensions); -- cgit v1.1