From 9eeb35e21e43c6a91fe45b03feb9cf1d42b88b65 Mon Sep 17 00:00:00 2001 From: "ananta@chromium.org" Date: Thu, 30 Sep 2010 21:38:50 +0000 Subject: Top level navigations are not sent to the host browser in the ChromeFrame NPAPI implementation. These include window.open requests, hrefs with target _blank, etc. The ChromeFrame NPAPI plugin needs to set the renderer pref which indicates that the host browser can handle top level requests. We also pass an additional flag in the CreateExternal tab IPC which indicates whether the host browser supports full tab mode browsing or not. This defaults to true for IE, as the activex implementation relies on being able to launch a new window with the attach external tab prefix. which assumes support for full tab mode for IE being available. If the host browser does not support full tab browsing the window.open request which comes into the ExternalTabContainer instance creates a dummy ExternalTabContainer instance which is destroyed when the top level navigation info is sent back to the host browser. This CL is a short term fix for the issues with the NPAPI ChromeFrame plugin. Will do some investigation into a better approach. Fixes bug http://code.google.com/p/chromium/issues/detail?id=57319 Test=Covered by existing ChromeFrame widget mode tests WidgetModeIE_SrcProperty and WidgetModeFF_SrcProperty Fixed incorrect assumptions in the test files used by these tests. Bug=57319 Review URL: http://codereview.chromium.org/3549006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61117 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome_frame/chrome_frame_npapi_unittest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'chrome_frame/chrome_frame_npapi_unittest.cc') diff --git a/chrome_frame/chrome_frame_npapi_unittest.cc b/chrome_frame/chrome_frame_npapi_unittest.cc index 324fad1..c0a0208 100644 --- a/chrome_frame/chrome_frame_npapi_unittest.cc +++ b/chrome_frame/chrome_frame_npapi_unittest.cc @@ -137,7 +137,7 @@ class TestNPAPIPrivilegedApi: public ::testing::Test { scoped_refptr launch_params( new ChromeFrameLaunchParams(GURL(), GURL(), FilePath(), profile_name, - extra_args, is_incognito, true)); + extra_args, is_incognito, true, false)); EXPECT_CALL(*mock_automation, Initialize(_, LaunchParamEq(true, extra_args, is_incognito, true))) -- cgit v1.1