From 36a26ed0faf7fb24d1991136cb5d6969f8042055 Mon Sep 17 00:00:00 2001 From: "robertshield@chromium.org" Date: Wed, 24 Mar 2010 03:09:05 +0000 Subject: Add a simple resource loader to Chrome Frame that is capable of finding, loading and extracting resources from the Chrome locale DLLs. Add the Chrome Frame resource strings to the Chrome .grds so they get built directly into the Chrome locale dlls. There is one remaining todo here, which is to load the dialog template into a grd + rc somewhere (probably in generated_resources.grd) and then get CF to load dialog templates from a different module. Will do that in another patch. BUG=24305 TEST=Chrome Frame when loaded on machines whose locales are not US English will display strings appropriate to those locales. Review URL: http://codereview.chromium.org/1240001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42423 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome_frame/chrome_frame_plugin.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'chrome_frame/chrome_frame_plugin.h') diff --git a/chrome_frame/chrome_frame_plugin.h b/chrome_frame/chrome_frame_plugin.h index 078a611..17fb6572 100644 --- a/chrome_frame/chrome_frame_plugin.h +++ b/chrome_frame/chrome_frame_plugin.h @@ -8,8 +8,11 @@ #include "base/ref_counted.h" #include "base/win_util.h" #include "chrome_frame/chrome_frame_automation.h" +#include "chrome_frame/simple_resource_loader.h" #include "chrome_frame/utils.h" +#include "grit/chromium_strings.h" + #define IDC_ABOUT_CHROME_FRAME 40018 // A class to implement common functionality for all types of @@ -181,10 +184,8 @@ END_MSG_MAP() // Override in most-derived class if needed. bool PreProcessContextMenu(HMENU menu) { // Add an "About" item. - // TODO: The string should be localized and menu should - // be modified in ExternalTabContainer:: once we go public. AppendMenu(menu, MF_STRING, IDC_ABOUT_CHROME_FRAME, - L"About Chrome Frame..."); + SimpleResourceLoader::Get(IDS_CHROME_FRAME_MENU_ABOUT).c_str()); return true; } -- cgit v1.1