From f5494d49ab74e3d116540b14db3457558f54c88e Mon Sep 17 00:00:00 2001 From: "jam@chromium.org" Date: Thu, 23 Dec 2010 22:15:34 +0000 Subject: Clean up Automation and Chrome Frame IPC code.-only use routed messages when needed-use routing IDs to avoid manually unpacking messages-remove data structures from IPC namespace (that should only be used for IPC code, and param traits)Note that I temporarily commented out part of a test in external_tab_test.cc because I couldn't figure out how to get the updated gmock macros to compile. Review URL: http://codereview.chromium.org/5998006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70105 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome_frame/chrome_frame_plugin.h | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'chrome_frame/chrome_frame_plugin.h') diff --git a/chrome_frame/chrome_frame_plugin.h b/chrome_frame/chrome_frame_plugin.h index 7acda3c..4f543b5 100644 --- a/chrome_frame/chrome_frame_plugin.h +++ b/chrome_frame/chrome_frame_plugin.h @@ -114,14 +114,13 @@ END_MSG_MAP() } protected: - virtual void OnNavigationFailed(int tab_handle, int error_code, - const GURL& gurl) { + virtual void OnNavigationFailed(int error_code, const GURL& gurl) { OnLoadFailed(error_code, gurl.spec()); } - virtual void OnHandleContextMenu(int tab_handle, HANDLE menu_handle, + virtual void OnHandleContextMenu(HANDLE menu_handle, int align_flags, - const IPC::MiniContextMenuParams& params) { + const MiniContextMenuParams& params) { if (!menu_handle || !automation_client_.get()) { NOTREACHED(); return; @@ -220,7 +219,7 @@ END_MSG_MAP() // Return true if menu command is processed, otherwise the command will be // passed to Chrome for execution. Override in most-derived class if needed. bool HandleContextMenuCommand(UINT cmd, - const IPC::MiniContextMenuParams& params) { + const MiniContextMenuParams& params) { return false; } -- cgit v1.1