From 079786397d052c14a2b1886dfb494c4bd4a9335c Mon Sep 17 00:00:00 2001 From: "ananta@chromium.org" Date: Wed, 5 May 2010 23:43:50 +0000 Subject: Cookies would not get set correctly in ChromeFrame in full tab mode. The code to set cookies in IE incorrectly parses the cookies into name value pairs. In this scenario we end up with an empty name string which causes cookies to not get set correctly. It appears that an empty name string is not treated on the same lines as NULL. In any case we should not be doing any parsing and should just set the cookie as is. This fixes bug http://code.google.com/p/chromium/issues/detail?id=42818. Added a unit test to validate this case. Bug=42818 Review URL: http://codereview.chromium.org/1917005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46523 0039d316-1c4b-4281-b951-d872f2087c98 --- .../test/data/fulltab_set_cookie_test.html | 67 ++++++++++++++++++++++ .../fulltab_set_cookie_test.html.mock-http-headers | 3 + 2 files changed, 70 insertions(+) create mode 100644 chrome_frame/test/data/fulltab_set_cookie_test.html create mode 100644 chrome_frame/test/data/fulltab_set_cookie_test.html.mock-http-headers (limited to 'chrome_frame/test/data') diff --git a/chrome_frame/test/data/fulltab_set_cookie_test.html b/chrome_frame/test/data/fulltab_set_cookie_test.html new file mode 100644 index 0000000..aa4bf40 --- /dev/null +++ b/chrome_frame/test/data/fulltab_set_cookie_test.html @@ -0,0 +1,67 @@ + + + + FullTab mode set cookie test + + + + + + + + This tests whether cookies get set correctly in full tab mode + + diff --git a/chrome_frame/test/data/fulltab_set_cookie_test.html.mock-http-headers b/chrome_frame/test/data/fulltab_set_cookie_test.html.mock-http-headers new file mode 100644 index 0000000..871fa9f --- /dev/null +++ b/chrome_frame/test/data/fulltab_set_cookie_test.html.mock-http-headers @@ -0,0 +1,3 @@ +HTTP/1.0 200 OK +Content-type: text/html +Set-Cookie: CF_FullTabDummyCookie=1;path=/ -- cgit v1.1