From bd635c097dfc689674d6b21c006850a7b07f23f4 Mon Sep 17 00:00:00 2001 From: "mbelshe@chromium.org" Date: Tue, 25 May 2010 20:21:16 +0000 Subject: Enable warning 4389 as an error on windows builds. This will make windows builds more similar to linux/mac, which already treat signed/ unsigned equality comparisons as warnings (and hence errors). BUG=44471 TEST=none Review URL: http://codereview.chromium.org/2081007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48186 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome_frame/test/exception_barrier_unittest.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'chrome_frame/test/exception_barrier_unittest.cc') diff --git a/chrome_frame/test/exception_barrier_unittest.cc b/chrome_frame/test/exception_barrier_unittest.cc index eeffd2a..73f006a 100644 --- a/chrome_frame/test/exception_barrier_unittest.cc +++ b/chrome_frame/test/exception_barrier_unittest.cc @@ -29,7 +29,7 @@ void TestSEHChainSane() { MEMORY_BASIC_INFORMATION info = { 0 }; // Note that we pass the address of the info struct just as a handy // moniker to anything at all inside our stack allocation - ASSERT_NE(0, ::VirtualQuery(&info, &info, sizeof(info))); + ASSERT_NE(0u, ::VirtualQuery(&info, &info, sizeof(info))); // The lower bound of our stack. // We use the address of info as a lower bound, this assumes that if this @@ -60,9 +60,9 @@ void TestSEHChainSane() { ASSERT_EQ(0, (reinterpret_cast(prev) & 0x00000003)); // find the module hosting the handler - ASSERT_NE(0, ::VirtualQuery(curr->handler, &info, sizeof(info))); + ASSERT_NE(0u, ::VirtualQuery(curr->handler, &info, sizeof(info))); wchar_t module_filename[MAX_PATH]; - ASSERT_NE(0, ::GetModuleFileName( + ASSERT_NE(0u, ::GetModuleFileName( reinterpret_cast(info.AllocationBase), module_filename, ARRAYSIZE(module_filename))); } -- cgit v1.1