From c3b4463c325d5a7f512130c02a68913cc52d20fe Mon Sep 17 00:00:00 2001 From: "ananta@chromium.org" Date: Wed, 28 Oct 2009 11:11:36 +0000 Subject: With the change in the constructor for the ChromeThread class, we are seeing a DCHECK fire in the Chrome frame network tests for whether the current thread is the UI thread. We need to invoke the correct constructor. The other fix is in our com_util::IDispatchImpl class where we end up crashing if we fail to find the type information for the passed in interface. Strangely this is failing for the IChromeFrame interface which is an IDispatch derivative and seems to be correctly registered. It also fails with the ATL IDispatchImpl classes though. However we should not crash here :) I also removed the NOTREACHED as it keeps firing on debug test runs. Will take a look at this closely later. TBR=tommi Review URL: http://codereview.chromium.org/343013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30333 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome_frame/test/net/fake_external_tab.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'chrome_frame/test') diff --git a/chrome_frame/test/net/fake_external_tab.cc b/chrome_frame/test/net/fake_external_tab.cc index 78430fe..9ada450 100644 --- a/chrome_frame/test/net/fake_external_tab.cc +++ b/chrome_frame/test/net/fake_external_tab.cc @@ -146,7 +146,8 @@ CFUrlRequestUnittestRunner::CFUrlRequestUnittestRunner(int argc, char** argv) EXPECT_TRUE(pss_subclass_->Subclass(fake_chrome_.user_data())); StartChromeFrameInHostBrowser(); // Register the main thread by instantiating it, but don't call any methods. - main_thread_.reset(new ChromeThread(ChromeThread::UI)); + main_thread_.reset(new ChromeThread(ChromeThread::UI, + MessageLoop::current())); DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI)); } -- cgit v1.1