From 559eec21d4f7a4a15d927176c2c49977eb111b97 Mon Sep 17 00:00:00 2001 From: "tfarina@chromium.org" Date: Wed, 11 Dec 2013 22:04:11 +0000 Subject: chrome_frame: Run vectored_handler_tests unit tests through base test suite. Using gtest.gyp:gtest_main is very uncommon in chromium tree, there are only two instances. By running it through base:run_all_unittests should be more robust. Previous CL was https://codereview.chromium.org/110983002 BUG=None TEST=vectored_handler_tests R=ananta@chromium.org,grt@chromium.org Review URL: https://codereview.chromium.org/103453006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240188 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome_frame/crash_reporting/crash_reporting.gyp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) (limited to 'chrome_frame') diff --git a/chrome_frame/crash_reporting/crash_reporting.gyp b/chrome_frame/crash_reporting/crash_reporting.gyp index a557bdd..653a28d 100644 --- a/chrome_frame/crash_reporting/crash_reporting.gyp +++ b/chrome_frame/crash_reporting/crash_reporting.gyp @@ -82,21 +82,21 @@ { 'target_name': 'vectored_handler_tests', 'type': 'executable', + 'dependencies': [ + '../../base/base.gyp:base', + '../../base/base.gyp:run_all_unittests', + '../../breakpad/breakpad.gyp:breakpad_handler', + '../../testing/gmock.gyp:gmock', + '../../testing/gtest.gyp:gtest', + 'crash_dll', + 'crash_report', + ], 'sources': [ 'nt_loader_unittest.cc', 'vectored_handler_unittest.cc', 'veh_test.cc', 'veh_test.h', ], - 'dependencies': [ - 'crash_dll', - 'crash_report', - '../../base/base.gyp:base', - '../../testing/gmock.gyp:gmock', - '../../testing/gtest.gyp:gtest', - '../../testing/gtest.gyp:gtest_main', - '../../breakpad/breakpad.gyp:breakpad_handler', - ], }, { 'target_name': 'minidump_test', -- cgit v1.1