From 5d60b0b9ddbab9d3cfc66aaf31ba03a1154382c1 Mon Sep 17 00:00:00 2001 From: "Yukawa@chromium.org" Date: Tue, 30 Jul 2013 20:24:30 +0000 Subject: Embed compatibility manifest into all *.exe files This CL introduces an automated and centralized way to embed compatibility manifest into all *.exe files. With this CL, a potential risk of behavioural inconsistency between production binaries and unit test binaries is resolved by enforcing the same compatibility context. This CL uses 'target_conditions' feature of gyp to inject manifest settings into each executable target. One tricky part is that some executables such as setup.exe and mini_installer.exe require external manifest file instead of embedded one when component build is enabled. See http://crbug.com/127233 for this. You can override the gyp variable 'win_exe_compatibility_manifest' locally for a given executable target to embed a custom compatibility manifest. BUG=260692 Review URL: https://chromiumcodereview.appspot.com/19275010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214427 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome_frame/chrome_frame.gyp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'chrome_frame') diff --git a/chrome_frame/chrome_frame.gyp b/chrome_frame/chrome_frame.gyp index fa5bae3..4225df5 100644 --- a/chrome_frame/chrome_frame.gyp +++ b/chrome_frame/chrome_frame.gyp @@ -952,8 +952,9 @@ 'SubSystem': '2', }, 'VCManifestTool': { - 'AdditionalManifestFiles': - '$(ProjectDir)\\resources\\npchrome_frame.dll.manifest', + 'AdditionalManifestFiles': [ + '$(ProjectDir)\\resources\\npchrome_frame.dll.manifest', + ], }, }, }], -- cgit v1.1