From d3709b5f91fe5d0d4accd7386da5a61743824b9e Mon Sep 17 00:00:00 2001 From: "ki.stfu" Date: Mon, 21 Sep 2015 17:56:52 -0700 Subject: Cleanup: Pass std::string as const reference from chromeos/ Passing std::string by reference can prevent extra copying of object. BUG=367418 TEST= R=zelidrag@chromium.org,derat@chromium.org,gauravsh@chromium.org Review URL: https://codereview.chromium.org/1353323002 Cr-Commit-Position: refs/heads/master@{#350078} --- chromeos/tools/onc_validator/onc_validator.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'chromeos/tools') diff --git a/chromeos/tools/onc_validator/onc_validator.cc b/chromeos/tools/onc_validator/onc_validator.cc index 84a9220..14ed891 100644 --- a/chromeos/tools/onc_validator/onc_validator.cc +++ b/chromeos/tools/onc_validator/onc_validator.cc @@ -82,7 +82,7 @@ void PrintHelp() { kStatusArgumentError); } -scoped_ptr ReadDictionary(std::string filename) { +scoped_ptr ReadDictionary(const std::string& filename) { base::FilePath path(filename); JSONFileValueDeserializer deserializer(path); deserializer.set_allow_trailing_comma(true); @@ -151,7 +151,7 @@ int main(int argc, const char* argv[]) { chromeos::onc::Validator::Result result; validator.ValidateAndRepairObject(signature, *onc_object, &result); - switch(result) { + switch (result) { case chromeos::onc::Validator::VALID: return kStatusValid; case chromeos::onc::Validator::VALID_WITH_WARNINGS: -- cgit v1.1