From f757c1ae7b770f3d7ba95e791f6e69e6f6eb98e1 Mon Sep 17 00:00:00 2001 From: "spang@chromium.org" Date: Thu, 7 Nov 2013 09:02:36 +0000 Subject: Allow printing component to be removed completely Using enable_printing=0 removes all of the source files of the printing component, but has no effect on its dependencies. It is wrong to empty out the target inside the target. If printing is disabled, then the dependency on printing.gyp is not needed and can be removed. This target was causing libgcrypt to be linked even when printing was disabled. That problem goes away with this change. Review URL: https://codereview.chromium.org/62793002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233563 0039d316-1c4b-4281-b951-d872f2087c98 --- cloud_print/service/service.gyp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'cloud_print') diff --git a/cloud_print/service/service.gyp b/cloud_print/service/service.gyp index 1bdc552..2e07037 100644 --- a/cloud_print/service/service.gyp +++ b/cloud_print/service/service.gyp @@ -57,7 +57,6 @@ '<(DEPTH)/google_apis/google_apis.gyp:google_apis', '<(DEPTH)/ipc/ipc.gyp:ipc', '<(DEPTH)/net/net.gyp:net', - '<(DEPTH)/printing/printing.gyp:printing', '<(DEPTH)/url/url.gyp:url_lib', 'service_resources', ], @@ -69,6 +68,11 @@ '<(DEPTH)/chrome/common_constants.gyp:common_constants', ], }], + ['enable_printing!=0', { + 'dependencies': [ + '<(DEPTH)/printing/printing.gyp:printing', + ], + }], ], 'sources': [ '<(DEPTH)/content/public/common/content_switches.h', -- cgit v1.1