From 0284b8af032487900d3882515a0a471ee1f28503 Mon Sep 17 00:00:00 2001
From: brettw <brettw@chromium.org>
Date: Mon, 24 Nov 2014 10:49:46 -0800
Subject: Add minimal components_unittests to GN build.

There are some linker errors for many components, but I wanted to get something enabled first.

Review URL: https://codereview.chromium.org/746773002

Cr-Commit-Position: refs/heads/master@{#305455}
---
 components/BUILD.gn | 56 ++++++++++++++++++++++++++++-------------------------
 1 file changed, 30 insertions(+), 26 deletions(-)

(limited to 'components/BUILD.gn')

diff --git a/components/BUILD.gn b/components/BUILD.gn
index f40d5ef..eaa056e 100644
--- a/components/BUILD.gn
+++ b/components/BUILD.gn
@@ -205,9 +205,6 @@ group("all_components") {
   }
 }
 
-# TODO(GYP) enable when it links.
-if (false) {
-
 # To add a unit test to this target, make a "unit_test" source_set in your
 # component (it's important to use a source_set instead of a static library or
 # no tests will run) and add a reference here. You can add more than one unit
@@ -222,27 +219,35 @@ test("components_unittests") {
   # test source set and not here.
   deps = [
     "//components/auto_login_parser:unit_tests",
-    "//components/autofill/content/browser:unit_tests",
-    "//components/autofill/core/browser:unit_tests",
-    "//components/autofill/core/common:unit_tests",
-    "//components/bookmarks/browser:unit_tests",
-    "//components/captive_portal:unit_tests",
-    "//components/cloud_devices/common:unit_tests",
-    "//components/component_updater:unit_tests",
-    "//components/content_settings/core/browser:unit_tests",
+    # TODO(GYP) enable the rest of these. Some will likely work, but some
+    # require extra dependencies to link properly.
+    #"//components/autofill/content/browser:unit_tests",
+    #"//components/autofill/core/browser:unit_tests",
+    #"//components/autofill/core/common:unit_tests",
+    #"//components/bookmarks/browser:unit_tests",
+    #"//components/captive_portal:unit_tests",
+    #"//components/cloud_devices/common:unit_tests",
+    #"//components/component_updater:unit_tests",
+    #"//components/content_settings/core/browser:unit_tests",
     "//components/content_settings/core/common:unit_tests",
-    "//components/crx_file:unit_tests",
-    "//components/data_reduction_proxy/core/browser:unit_tests",
-    "//components/data_reduction_proxy/core/common:unit_tests",
-    "//components/dom_distiller/core:unit_tests",
-    "//components/domain_reliability:unit_tests",
-    "//components/login:unit_tests",
-    "//components/metrics:unit_tests",
-    "//components/omnibox:unit_tests",
-    "//components/ownership:unit_tests",
-    "//components/proximity_auth:unit_tests",
-    "//components/variations:unit_tests",
-    "//components/web_resource:unit_tests",
+    #"//components/crx_file:unit_tests",
+    #"//components/data_reduction_proxy/core/browser:unit_tests",
+    #"//components/data_reduction_proxy/core/common:unit_tests",
+    #"//components/dom_distiller/core:unit_tests",
+    #"//components/domain_reliability:unit_tests",
+    #"//components/login:unit_tests",
+    #"//components/metrics:unit_tests",
+    #"//components/omnibox:unit_tests",
+    #"//components/ownership:unit_tests",
+    #"//components/proximity_auth:unit_tests",
+    #"//components/variations:unit_tests",
+    #"//components/web_resource:unit_tests",
+
+    # These are the deps required by the code in this target.
+    "//base",
+    "//base/test:test_support",
+    "//content/test:test_support",
+    "//ui/base",
   ]
 
   # TODO(GYP) need this target.
@@ -252,8 +257,7 @@ test("components_unittests") {
   #configs += [ "//components/precache/core:precache_config" ]
 
   if (toolkit_views) {
-    deps += [ "//components/constrained_window:unit_tests" ]
+    # TODO(GYP) enable this as above.
+    #deps += [ "//components/constrained_window:unit_tests" ]
   }
 }
-
-}
-- 
cgit v1.1