From a7ff1b291cd328e9584779a4bb9101fa9a3c01ad Mon Sep 17 00:00:00 2001 From: brettw Date: Thu, 16 Jul 2015 10:49:29 -0700 Subject: Remove some legacy versions of StartsWith and EndsWith. This just replaces true -> base::CompareCase::SENSITIVE false -> base::CompareCase::INSENSITIVE_ASCII I checked the insensitive cases to make sure they're not doing anything suspicious. The old version is a sometimes-correct Unicode comparison so converting to INSENSTITIVE_ASCII isn't a no-op. However, generally the prefix/suffix checking is done against a hardcoded string so there were very few cases to actually look at. extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc has a not-quite search-and-replace change where I changed the type of a class variable. BUG=506255 TBR=jam Reland of http://crrev.com/1239493005 Review URL: https://codereview.chromium.org/1233043003 Cr-Commit-Position: refs/heads/master@{#339071} --- components/search/search.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'components/search') diff --git a/components/search/search.cc b/components/search/search.cc index 8c50d16..92b8ccb 100644 --- a/components/search/search.cc +++ b/components/search/search.cc @@ -90,7 +90,8 @@ bool GetFieldTrialInfo(FieldTrialFlags* flags) { kInstantExtendedFieldTrialName); } - if (base::EndsWith(group_name, kDisablingSuffix, true)) + if (base::EndsWith(group_name, kDisablingSuffix, + base::CompareCase::SENSITIVE)) return false; // We have a valid trial that isn't disabled. Extract the flags. -- cgit v1.1