From 59b968271f2a2fb948ad110f0ed1b3da870b0eb5 Mon Sep 17 00:00:00 2001 From: "anujk.sharma" Date: Tue, 16 Sep 2014 09:52:38 -0700 Subject: Code refactor related to WeakPtrFactory in src/components module Changing in the intialization order of WeakPtrFactory in src/components module such that all member variables should appear before the WeakPtrFactory to ensure that any WeakPtrs to Controller are invalidated before its members variable's destructors are executed, rendering them invalid. BUG=303818 Review URL: https://codereview.chromium.org/573623002 Cr-Commit-Position: refs/heads/master@{#295084} --- components/web_cache/browser/web_cache_manager.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'components/web_cache') diff --git a/components/web_cache/browser/web_cache_manager.h b/components/web_cache/browser/web_cache_manager.h index 0945ec5..5d64992 100644 --- a/components/web_cache/browser/web_cache_manager.h +++ b/components/web_cache/browser/web_cache_manager.h @@ -229,10 +229,10 @@ class WebCacheManager : public content::NotificationObserver { // recently than they have been active. std::set inactive_renderers_; - base::WeakPtrFactory weak_factory_; - content::NotificationRegistrar registrar_; + base::WeakPtrFactory weak_factory_; + DISALLOW_COPY_AND_ASSIGN(WebCacheManager); }; -- cgit v1.1