From 1f57fbe4ba473286d732c132df5e3b410a3faaae Mon Sep 17 00:00:00 2001 From: "blundell@chromium.org" Date: Sat, 12 Oct 2013 07:14:32 +0000 Subject: Eliminate usage of content url constants in Autofill core code. Instead, hardcode the HTTPS scheme (as is done in e.g. //net). BUG=303006 Review URL: https://codereview.chromium.org/25533005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228325 0039d316-1c4b-4281-b951-d872f2087c98 --- components/autofill/core/browser/DEPS | 1 - components/autofill/core/browser/autofill_manager.cc | 5 +++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'components') diff --git a/components/autofill/core/browser/DEPS b/components/autofill/core/browser/DEPS index 9b93c76..d28697c 100644 --- a/components/autofill/core/browser/DEPS +++ b/components/autofill/core/browser/DEPS @@ -15,7 +15,6 @@ include_rules = [ "!content/public/browser/browser_context.h", "!content/public/browser/render_view_host.h", "!content/public/browser/web_contents.h", - "!content/public/common/url_constants.h", "!third_party/WebKit/public/web/WebAutofillClient.h", ] diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc index 5877ab4..d6d55df 100644 --- a/components/autofill/core/browser/autofill_manager.cc +++ b/components/autofill/core/browser/autofill_manager.cc @@ -46,7 +46,6 @@ #include "content/public/browser/browser_context.h" #include "content/public/browser/render_view_host.h" #include "content/public/browser/web_contents.h" -#include "content/public/common/url_constants.h" #include "grit/component_strings.h" #include "third_party/WebKit/public/web/WebAutofillClient.h" #include "ui/base/l10n/l10n_util.h" @@ -124,7 +123,9 @@ bool SectionIsAutofilled(const FormStructure& form_structure, } bool FormIsHTTPS(const FormStructure& form) { - return form.source_url().SchemeIs(content::kHttpsScheme); + // TODO(blundell): Change this to use a constant once crbug.com/306258 is + // fixed. + return form.source_url().SchemeIs("https"); } // Uses the existing personal data in |profiles| and |credit_cards| to determine -- cgit v1.1