From 6d5c060a34a2a9e8b4ccb4169b80153040fcacee Mon Sep 17 00:00:00 2001 From: "fsamuel@chromium.org" Date: Tue, 18 Jun 2013 11:27:06 +0000 Subject: : Escape key unlocks pointer by default With this CL, the ESC key will now, by default unlock the pointer if it was locked by a webview. The Chrome App can override this behavior by handling the keydown event in the embedder and preventing default. BUG=233793 Review URL: https://chromiumcodereview.appspot.com/16955007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206936 0039d316-1c4b-4281-b951-d872f2087c98 --- content/browser/browser_plugin/browser_plugin_embedder.h | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'content/browser/browser_plugin/browser_plugin_embedder.h') diff --git a/content/browser/browser_plugin/browser_plugin_embedder.h b/content/browser/browser_plugin/browser_plugin_embedder.h index ccc4544..7e87115 100644 --- a/content/browser/browser_plugin/browser_plugin_embedder.h +++ b/content/browser/browser_plugin/browser_plugin_embedder.h @@ -35,6 +35,7 @@ class BrowserPluginGuestManager; class BrowserPluginHostFactory; class RenderWidgetHostImpl; class WebContentsImpl; +struct NativeWebKeyboardEvent; class CONTENT_EXPORT BrowserPluginEmbedder : public WebContentsObserver { public: @@ -53,6 +54,12 @@ class CONTENT_EXPORT BrowserPluginEmbedder : public WebContentsObserver { // Called when embedder's |rwh| has sent screen rects to renderer. void DidSendScreenRects(); + // Called when embedder's WebContentsImpl has unhandled keyboard input. + // Returns whether the BrowserPlugin has handled the keyboard event. + // Currently we are only interested in checking for the escape key to + // unlock hte guest's pointer lock. + bool HandleKeyboardEvent(const NativeWebKeyboardEvent& event); + // Overrides factory for testing. Default (NULL) value indicates regular // (non-test) environment. static void set_factory_for_testing(BrowserPluginHostFactory* factory) { -- cgit v1.1